-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean output if json parameter is not set #378
Comments
Thanks @gavignon ! We'll look into it, it may introduce breaking changes but it will be closer to the standard behavior |
I agree that we were to launch the plugin today we should have implemented the behaviour described by @gavignon . But since SGD is already heavily used, I have mixed feeling about introducing a breaking change. @gavignon are you facing an issue that would be solved by this change? |
Thanks for the quick feedback @mehdisfdc @scolladon ! This is not a show stopper, I would like this enhancement to increase the readability in the jobs, as this output is not needed. |
I like the idea of a new |
Clean output if json parameter is not set
Remove json output if --json parameter is not set, use spinner instead.
What is the current result ?
sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT>
Result:
{ "error": null, "output": "<OUTPUT>", "success": true, "warnings": [] }
What are the expected results ?
Without JSON parameter:
sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT>
Result:
Generating delta...done
or nothingWith JSON parameter
sfdx sgd:source:delta -s force-app -f <FROM> -t <TO> -o <OUTPUT> --json
Result:
{ "error": null, "output": "<OUTPUT>", "success": true, "warnings": [] }
The text was updated successfully, but these errors were encountered: