Should've read the Slack docs about channel mentions by bots

scobal · Mar 6, 2015 · 2723221 · 2723221
1 parent e890334
commit 2723221
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/seyren-core/src/main/java/com/seyren/core/service/notification/SlackNotificationService.java b/seyren-core/src/main/java/com/seyren/core/service/notification/SlackNotificationService.java
@@ -120,7 +120,7 @@ public String apply(Alert input) {
             }
         }));
 
-        String channel = subscription.getTarget().contains("!") ? "@channel" : "";
+        String channel = subscription.getTarget().contains("!") ? "<!channel>" : "";
 
         final String state = check.getState().toString();
 

diff --git a/...core/src/test/java/com/seyren/core/service/notification/SlackNotificationServiceTest.java b/...core/src/test/java/com/seyren/core/service/notification/SlackNotificationServiceTest.java
@@ -112,7 +112,7 @@ public void basicSlackTest() {
 
         assertThat(content, Matchers.containsString("token="));
         assertThat(content, Matchers.containsString("&channel=target"));
-        assertThat(content, not(Matchers.containsString(encode("@channel"))));
+        assertThat(content, not(Matchers.containsString(encode("<!channel>"))));
         assertThat(content, Matchers.containsString(encode("ERROR test-check")));
         assertThat(content, Matchers.containsString(encode("/#/checks/123")));
         assertThat(content, Matchers.containsString("&username=Seyren"));
@@ -161,7 +161,7 @@ public void mentionChannelWhenTargetContainsExclamationTest() {
 
         assertThat(content, Matchers.containsString("token="));
         assertThat(content, Matchers.containsString("&channel=target"));
-        assertThat(content, Matchers.containsString(encode("@channel")));
+        assertThat(content, Matchers.containsString(encode("<!channel>")));
         assertThat(content, Matchers.containsString(encode("ERROR test-check")));
         assertThat(content, Matchers.containsString(encode("/#/checks/123")));
         assertThat(content, Matchers.containsString("&username=Seyren"));