Skip to content

This pull request adds building and testing PHP-84 in RHEL10#530

Open
phracek wants to merge 9 commits into
sclorg:masterfrom
phracek:support_build_tests_php84
Open

This pull request adds building and testing PHP-84 in RHEL10#530
phracek wants to merge 9 commits into
sclorg:masterfrom
phracek:support_build_tests_php84

Conversation

@phracek
Copy link
Copy Markdown
Member

@phracek phracek commented May 20, 2026

This pull request enables building and testing PHP-84 on RHEL10.

It contains these commits:

  • PHP8.4 1/3 - move latest dir -> 8.3 is moved to 8.4
  • PHP8.4 2/3 - copy sources 8.4 to 8.3
  • PHP8.4 3/3 - replaces version 8.3 with 8.4
  • Update build-and-push action
  • Update RHEL10 dockerfile with versioned php8.4 packages.

The php-8.4 package that have been removed are: php-opcache, and php-apcu.

Similar PR is here: sclorg/s2i-nodejs-container#495

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - RHEL9 - Unsubscribed host - 8.2[pending]
  • Testing Farm - RHEL10 - Unsubscribed host - PyTest - 8.3[pending]
  • Testing Farm - RHEL10 - Unsubscribed host - PyTest - 8.4[pending]
  • Testing Farm - RHEL9 - 8.2[pending]
  • Testing Farm - RHEL10 - 8.4[pending]
  • Testing Farm - CentOS Stream 10 - PyTest - 8.3[pending]
  • Testing Farm - CentOS Stream 10 - PyTest - 8.4[pending]
  • Testing Farm - RHEL8 - 8.2[pending]
  • Testing Farm - RHEL9 - Unsubscribed host - PyTest - 8.3[pending]
  • Testing Farm - CentOS Stream 10 - 8.4[pending]
  • Testing Farm - RHEL9 - PyTest - 8.3[pending]
  • Testing Farm - CentOS Stream 9 - PyTest - 8.3[pending]
  • Testing Farm - RHEL9 - Unsubscribed host - PyTest - 8.0[pending]

🔴 Review - Missing review from a member (1 required)


Triggered by Workflow Run

@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 20, 2026

[test][test-pytest]

@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 20, 2026

@remicollet Can you please take a look at it. Adding to CC as well @jplesnik

One issue that I have spotted is: The php-8.4 package that have been removed are: php-opcache, and php-apcu. I did not find and php84 packages.

phracek added 5 commits May 20, 2026 13:15
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
php is versioned based.

php-opcache was removed as it does not version based PHP package
php-mysqli was renamed to php84.mysqlnd

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the support_build_tests_php84 branch from 2524041 to 1659438 Compare May 20, 2026 11:15
@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 20, 2026

rebased against master
[test][test-pytest]

@remicollet
Copy link
Copy Markdown
Contributor

@remicollet Can you please take a look at it. Adding to CC as well @jplesnik

I noticed

  • Dockerfile.c10s doesn't use the name prefix (php8.4* in INSTALL_EXTS)
  • c9s/rhel9 is not yet ready for 8.4 (this will be a module)
  • perhaps you can also add php 8.5 (Fedora 44) (perhaps another PR)
  • INSTALL_EXTS uses php-zip and php-redis, this works, BTW package names are php8.4-pecl-zip and php8.4-pecl-redis6

One issue that I have spotted is: The php-8.4 package that have been removed are: php-opcache, and php-apcu. I did not find and php84 packages.

  • php-apcu is provided by php8.4-pecl-apcu
  • php-opcache is provided by php8.4-common, built statically, so always present

@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 20, 2026

Let's try one more round sclorg/ci-actions#4

[test]

@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 20, 2026

[test]

Comment thread 8.4/root/opt/app-root/etc/php.d/10-opcache.ini.template Outdated
As opcache is always present. Let's remove two rows from
PHP configuration file.
8.4/root/opt/app-root/etc/php.d/10-opcache.ini.template
Suggested by @remicollet.

Thanks for review @remicollet.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 21, 2026

Dockerfile.c10s has been updated with version based PHP packages.
5d84491

[test][test-pytest]

@pkhartsk
Copy link
Copy Markdown
Contributor

[test][test-pytest]

@github-actions
Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - 8.4Fedora-latestx86_64✅ passed21.05.2026 09:05:207min 57stest pipeline

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - PyTest - 8.3Fedora-latestx86_64✅ passed21.05.2026 12:18:027min 37stest pipeline
Fedora - PyTest - 8.2Fedora-latestx86_64✅ passed21.05.2026 12:36:237min 48stest pipeline
Fedora - 8.2Fedora-latestx86_64✅ passed21.05.2026 12:40:257min 4stest pipeline
CentOS Stream 10 - PyTest - 8.3CentOS-Stream-10x86_64✅ passed21.05.2026 12:17:5810min 45stest pipeline
CentOS Stream 10 - PyTest - 8.4CentOS-Stream-10x86_64✅ passed21.05.2026 12:17:5910min 7stest pipeline
CentOS Stream 10 - 8.3CentOS-Stream-10x86_64✅ passed21.05.2026 12:43:1211min 24stest pipeline
CentOS Stream 9 - PyTest - 8.3CentOS-Stream-9x86_64✅ passed21.05.2026 12:18:2010min 7stest pipeline
CentOS Stream 9 - 8.3CentOS-Stream-9x86_64✅ passed21.05.2026 12:30:4311min 42stest pipeline
RHEL8 - PyTest - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed21.05.2026 12:30:2112min 56stest pipeline
RHEL8 - PyTest - 7.4RHEL-8.10.0-Nightlyx86_64✅ passed21.05.2026 12:42:2117min 53stest pipeline
RHEL10 - Unsubscribed host - PyTest - 8.3RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:17:5616min 20stest pipeline
RHEL10 - PyTest - 8.3RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:40:3522min 7stest pipeline
Fedora - PyTest - 8.4Fedora-latestx86_64✅ passed21.05.2026 12:17:567min 32stest pipeline
RHEL9 - Unsubscribed host - PyTest - 8.2RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:26:3718min 44stest pipeline
RHEL9 - 8.2RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:17:5728min 3stest pipeline
RHEL9 - PyTest - 8.2RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:32:2923min 21stest pipeline
RHEL9 - 8.3RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:46:2230min 4stest pipeline
RHEL8 - 7.4RHEL-8.10.0-Nightlyx86_64✅ passed21.05.2026 12:26:3213min 12stest pipeline
RHEL9 - 8.0RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:39:0026min 42stest pipeline
RHEL10 - Unsubscribed host - PyTest - 8.4RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:17:5616min 24stest pipeline
Fedora - 8.3Fedora-latestx86_64✅ passed21.05.2026 09:21:548min 14stest pipeline
RHEL8 - 8.2RHEL-8.10.0-Nightlyx86_64✅ passed21.05.2026 12:18:0113min 59stest pipeline
RHEL10 - Unsubscribed host - 8.3RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 09:15:4416min 38stest pipeline
RHEL9 - Unsubscribed host - 8.3RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:26:2919min 3stest pipeline
RHEL9 - Unsubscribed host - 8.0RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:40:5828min 21stest pipeline
RHEL9 - PyTest - 8.3RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:18:0520min 43stest pipeline
CentOS Stream 10 - 8.4CentOS-Stream-10x86_64✅ passed21.05.2026 12:18:039min 47stest pipeline
RHEL9 - PyTest - 8.0RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:30:2021min 3stest pipeline
RHEL10 - 8.3RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:28:2419min 8stest pipeline
RHEL10 - PyTest - 8.4RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:37:0921min 43stest pipeline
RHEL9 - Unsubscribed host - PyTest - 8.0RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:26:1418min 46stest pipeline
RHEL9 - Unsubscribed host - 8.2RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:17:5523min 45stest pipeline
RHEL10 - 8.4RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:17:5720min 26stest pipeline
Fedora - 8.4Fedora-latestx86_64✅ passed21.05.2026 12:18:066min 46stest pipeline
RHEL9 - Unsubscribed host - PyTest - 8.3RHEL-9.8.0-Nightlyx86_64✅ passed21.05.2026 12:18:0218min 25stest pipeline
RHEL10 - Unsubscribed host - 8.4RHEL-10.2-Nightlyx86_64✅ passed21.05.2026 12:44:4824min 54stest pipeline

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek force-pushed the support_build_tests_php84 branch from 5b158fc to 4d8e619 Compare May 21, 2026 10:06
`php -m` is mentioned `redis`

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Copy Markdown
Member Author

phracek commented May 21, 2026

[test][test-pytest]

and better handling

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
Copy link
Copy Markdown
Contributor

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants