Fix is_little_endian bug- always returns true (#19)

WYishai · ValarDragon · commit b05476f03cbb · 2020-09-25T17:12:32.000-05:00
Authored-by: Yishai Wiesner &lt;ywiesner@bgu.ac.il&gt;
diff --git a/libff/common/utils.cpp b/libff/common/utils.cpp
@@ -90,7 +90,7 @@ bool is_little_endian()
 {
     uint64_t a = 0x12345678;
     unsigned char *c = (unsigned char*)(&a);
-    return (*c = 0x78);
+    return (*c == 0x78);
 }
 
 std::string FORMAT(const std::string &prefix, const char* format, ...)

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ bool is_little_endian()`
`90`	`90`	`{`
`91`	`91`	`uint64_t a = 0x12345678;`
`92`	`92`	`unsigned char c = (unsigned char)(&a);`
`93`		`- return (*c = 0x78);`
	`93`	`+ return (*c == 0x78);`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`std::string FORMAT(const std::string &prefix, const char* format, ...)`