Merge branch 'remove-defh-strcasecmp' into 'master'

replace str(n)casecmp by SCIPstr(n)casecmp

See merge request integer/scip!3544

Author: svigerske

CHANGELOG

@@ -45,6 +45,10 @@ Interface changes
 - SCIPdebugClearSol() for clearing the debug solution
 - Renamed XML functions to avoid name clash with libxml2 by adding "SCIP": SCIPxmlProcess(), SCIPxmlNewNode(), SCIPxmlNewAttr(), SCIPxmlAddAttr(), SCIPxmlAppendChild(), SCIPxmlFreeNode(), SCIPxmlShowNode(), SCIPxmlGetAttrval(), SCIPxmlFirstNode(), SCIPxmlNextNode(), SCIPxmlFindNode(), SCIPxmlFindNodeMaxdepth(), SCIPxmlNextSibl(), SCIPxmlPrevSibl(), SCIPxmlFirstChild(), SCIPxmlLastChild(), SCIPxmlGetName(), SCIPxmlGetLine(), SCIPxmlGetData(), SCIPxmlFindPcdata().
 
+### Changes in preprocessor macros
+
+- removed `#define` of `strcasecmp` and `strncasecmp` (in case of Windows builds) in scip/def.h;
+  use SCIPstr(n)casecmp() (scip/pub_misc.h) instead
 
 ### Command line interface
 

src/lpi/lpi_xprs.c

@@ -40,7 +40,8 @@
 
 #include <assert.h>
 #include <string.h>
-#if defined(_WIN32) || defined(_WIN64)
+#ifdef _MSC_VER
+#define strcasecmp _stricmp
 #else
 #include <strings.h> /*lint --e{766}*/
 #endif

src/scip/def.h

@@ -99,14 +99,6 @@
 #define SCIP_Shortbool uint8_t               /**< type used for Boolean values with less space */
 #endif
 
-/*
- * Add some macros for differing functions on Windows
- */
-#ifdef _WIN32
-#define strcasecmp _stricmp
-#define strncasecmp _strnicmp
-#endif
-
 /*
  * Define the macro SCIP_EXPORT if it is not included from the generated header
  */