Skip to content

private/app/launcher: unwrap errors fully to avoid hiding cause #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

private/app/launcher: unwrap errors fully to avoid hiding cause #4783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion private/app/launcher/launcher_unix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package launcher

import (
"context"
"errors"
"fmt"
"os"
"path/filepath"
Expand Down Expand Up @@ -46,7 +47,7 @@ type Application struct {
// Run will exit the application if it encounters a fatal error.
func (a *Application) Run() {
if err := a.run(); err != nil {
fmt.Fprintf(a.getErrorWriter(), "fatal error: %v\n", err)
fmt.Fprintf(a.getErrorWriter(), "fatal error: %v\n %#v\n", err, errors.Unwrap(err))
Copy link
Contributor

@oncilla oncilla Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this still produces hard to read error messages.

Instead, I think you should use errors.As together with toml.StrictMissingError and toml.DecodeError

If error matches -> pretty print to stderr

I would also leave this line unchanged.

os.Exit(1)
}
}
Expand Down
3 changes: 2 additions & 1 deletion private/app/launcher/launcher_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package launcher

import (
"context"
"errors"
"fmt"
"os"
"path/filepath"
Expand Down Expand Up @@ -73,7 +74,7 @@ type Application struct {
// Run will exit the application if it encounters a fatal error.
func (a *Application) Run() {
if ec, err := a.run(); err != nil {
fmt.Fprintf(a.getErrorWriter(), "fatal error: %v\n", err)
fmt.Fprintf(a.getErrorWriter(), "fatal error: %v\n %#v\n", err, errors.Unwrap(err))
os.Exit(ec)
}
}
Expand Down
Loading