router: add tcp support for dispatching to endhost #4703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
JordiSubira
changed the title
jiceathome
approved these changes
Feb 14, 2025
Contributor
jiceathome
left a comment
jiceathome
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @JordiSubira)
JordiSubira
force-pushed
the
router_tcp_support
branch
from
f4a2411 to
5e20bbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #4698.
I followed the same principle that we use for the other protocols, i.e., we dispatch to the mapped port if the destination port is within the dispatched port range. Otherwise, it is sent to the fix
EndhostPort.This makes it compatible with implementations following the "Wireguard"-model, i.e., sending the encapsulated traffic over a fix UDP port, e.g., the SCION-IP translator; or alternative implementations that map the underlay port to the application port, e.g., what we do with SCMP or UDP/SCION, provided proper
dispatched_portsconfiguration.