Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP addr of service should not be hidden in Metrics config. #2312

Open
lukedirtwalker opened this issue Jan 9, 2019 · 1 comment
Open
Assignees
Labels
feature New feature or request i/breaking change PR that breaks forwards or backwards compatibility i/help wanted Nobody is working on this at the moment

Comments

@lukedirtwalker
Copy link
Collaborator

lukedirtwalker commented Jan 9, 2019

In env.Metrics we specify the address we export Prometheus metrics. But we deliberately also serve other data on this address. Therefore we should change:

  1. Rename Metrics.Prometheus config to HTTP.Address and add a flag whether Prometheus should be enabled.
  2. Do not call http.ListenAndServe in env.StartPrometheus it should be the app's responsibility to do so.
@lukedirtwalker lukedirtwalker changed the title env.StartPrometheus should use a fixed handler in http.ListenAndServe() HTTP addr of service should not be hidden in Metrics config. Jan 9, 2019
@lukedirtwalker lukedirtwalker added feature New feature or request i/breaking change PR that breaks forwards or backwards compatibility refactor Change that focuses around reducing tech debt labels Jan 6, 2020
@scrye scrye added the i/good first issue Good for newcomers label May 4, 2020
@scrye scrye added i/help wanted Nobody is working on this at the moment and removed refactor Change that focuses around reducing tech debt i/good first issue Good for newcomers labels May 4, 2020
@matzf
Copy link
Contributor

matzf commented May 27, 2022

We now have a separate [metrics] and [api] configuration sections, to define the listen address of separate web services responsible for the prometheus metrics and OpenAPI, respectively. The applications start both services explicitly if configured, as required in 2 above.

The StatusPages APIs are still available via both the "metrics" and the "api" server. This does not appear to make much sense and should be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request i/breaking change PR that breaks forwards or backwards compatibility i/help wanted Nobody is working on this at the moment
Projects
None yet
Development

No branches or pull requests

3 participants