Skip to content

[MRG] DOC fix intersphinx #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2017

Conversation

glemaitre
Copy link
Member

Reference Issue

What does this implement/fix? Explain your changes.

Any other comments?

@pep8speaks
Copy link

pep8speaks commented Oct 11, 2017

Hello @glemaitre! Thanks for updating the PR.

  • In the file doc/conf.py, following are the PEP8 issues :

Line 24:1: E402 module level import not at top of file
Line 25:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 88:1: E402 module level import not at top of file
Line 312:80: E501 line too long (86 > 79 characters)
Line 336:80: E501 line too long (84 > 79 characters)

Comment last updated on November 01, 2017 at 18:47 Hours UTC

@glemaitre glemaitre changed the title DOC fix intersphinx [WIP] DOC fix intersphinx Oct 12, 2017
@codecov
Copy link

codecov bot commented Oct 12, 2017

Codecov Report

Merging #356 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          68       68           
  Lines        3924     3924           
=======================================
  Hits         3875     3875           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81317df...bc011c9. Read the comment docs.

@glemaitre glemaitre changed the title [WIP] DOC fix intersphinx [MRG] DOC fix intersphinx Nov 1, 2017
@glemaitre
Copy link
Member Author

@chkoar Finally solved this stupid mistake. Ready to be merged

@chkoar chkoar merged commit 69a80c0 into scikit-learn-contrib:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants