NeighbourhoodCleaningRule fix #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check the PEP8. It seems that you have a line larger than 79 characters. |
|
Also you need to add your contribution in the log, under Bug Fixes https://raw.githubusercontent.com/scikit-learn-contrib/imbalanced-learn/master/doc/whats_new.rst |
|
thanks 👍 |
christophe-rannou
pushed a commit
to christophe-rannou/imbalanced-learn
that referenced
this pull request
Apr 3, 2017
…kit-learn-contrib#230) * main fix: selecting neighbours instead of minority class misclassified samples * tests fix: 5-th sample additionally removed by new (fixed) rule * docstring fix: 2 more example samples removed by new (fixed) rule * fixed too long line * changelog * changelog: target name added
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
…kit-learn-contrib#230) * main fix: selecting neighbours instead of minority class misclassified samples * tests fix: 5-th sample additionally removed by new (fixed) rule * docstring fix: 2 more example samples removed by new (fixed) rule * fixed too long line * changelog * changelog: target name added
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
…kit-learn-contrib#230) * main fix: selecting neighbours instead of minority class misclassified samples * tests fix: 5-th sample additionally removed by new (fixed) rule * docstring fix: 2 more example samples removed by new (fixed) rule * fixed too long line * changelog * changelog: target name added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: for misclassified positive samples they are returned themselves but not their negative neighbours (so behaviour for positive result of IF statement is wrong). #227