Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve instance hardness threshold user guide #1029

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

solegalli
Copy link
Contributor

relates to #853

making smaller PRs as requested

@@ -365,12 +365,32 @@ and the output a 3 nearest neighbors classifier. The class can be used as::

.. _instance_hardness_threshold:

Additional undersampling techniques
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user guide is divided into controlled undersampling (RUS and nearmiss) and cleaning (all the others). I felt we needed another headline for IHT


The figure below gives another examples on some toy data.
The figure below shows examples of instance hardness undersampling on a toy dataset.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is FunctionSampler in the image below? random undersampling? Would be good to make it clear so the user knows what they are looking at in the plot

@solegalli
Copy link
Contributor Author

@glemaitre ready for review

@glemaitre glemaitre merged commit 7d5509c into scikit-learn-contrib:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants