Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improve documentation of RandomUnderSampler #1019

Merged
merged 5 commits into from
Jul 11, 2023

Conversation

solegalli
Copy link
Contributor

related to #853

Creating smaller PRs as requested

@solegalli
Copy link
Contributor Author

@glemaitre ready for review

@glemaitre glemaitre changed the title rewords rus user guide DOC improve documentation of RandomUnderSampler Jul 10, 2023
@@ -77,6 +77,12 @@ and are meant for cleaning the feature space.
Controlled under-sampling techniques
------------------------------------

Controlled under-sampling techniques reduce the number of observations from the majority
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use directly targeted classes without the term "majority"

doc/under_sampling.rst Outdated Show resolved Hide resolved
doc/under_sampling.rst Outdated Show resolved Hide resolved
solegalli and others added 3 commits July 11, 2023 12:03
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@solegalli
Copy link
Contributor Author

done.

(I make a note to update the oversamplers including ros on separate prs)

@glemaitre glemaitre merged commit d597b05 into scikit-learn-contrib:master Jul 11, 2023
@glemaitre
Copy link
Member

Thanks @solegalli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants