feat: textual-update #115
Merged
feat: textual-update #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
elie/feat/update-textual
branch
from
029d484 to
09f639f
Compare
henryiii
reviewed
Apr 26, 2023
henryiii
reviewed
Apr 26, 2023
henryiii
reviewed
Apr 26, 2023
henryiii
reviewed
Apr 26, 2023
Member
|
Looks like the nesting issue was (at least partially) fixed on main, but this branch was based on an old commit. Rebased, added typing and made Ruff happy, and did some minor cleanup. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
for more information, see https://pre-commit.ci
henryiii
force-pushed
the
elie/feat/update-textual
branch
from
4d0a347 to
752087e
Compare
henryiii
approved these changes
Apr 26, 2023
Member
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
I think this looks good to go!
Member
|
I'm going to merge this. Future changes should be new PRs focus on single features / fixes (like tabs or keyboard navigation). We can discuss releasing when we meet tomorrow. |
Member
|
We should probably update the gif and logo in the readme around release time, too. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to do some fixes to pass ruff and mypy pre-commit hooks