-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix library dedection for pypy 3.9 #673
Conversation
Where does |
scikit-build is not using
|
Ahh, right, that was a bug in the release and was fixed. It will be part of this week's release. |
Okay, then we should wait to merge this PR. I will have a look again once the new release is out. Even though the current state should also work with the upcoming release. |
for more information, see https://pre-commit.ci
@mattip, I can confirm that LDLIBRARY is set correctly in the nightly build. But there is no updated release yet. @henryiii, this pact tries to avoid guessing the library path by constructing it from config vars. If this fails, it falls back to the matrix to guess the path. The matrix has also been adjusted to work with newer pypy releases. Just in case. What do you think? |
I will be releasing a new version once CPython releases the upcoming security fix release (March 15?). I want to make sure I got all the fixes into PyPy. |
Fantastic, thank you very much! |
The library name in pypy 3.9 has changed. The '-c' moved to the end. This PR patches the candidate matrix to "make it work". It doesn't really fit nicely in the current matrix, though.