chore: enable more ruff using config #1179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
LecrisUT
reviewed
Nov 12, 2025
| dir = Path("dir") | ||
| dir.mkdir() | ||
| file1 = dir / "file" | ||
| dir_dir = Path("dir") |
Collaborator
There was a problem hiding this comment.
It reads so derpy 🤣. What about dir_path
Collaborator
Author
There was a problem hiding this comment.
The others use _dir around it?
Collaborator
Author
There was a problem hiding this comment.
Maybe should change the dir folder name to something else?
Collaborator
There was a problem hiding this comment.
Well it's only the instance here isn't it?
Maybe should change the dir folder name to something else?
Sure, that would also help put it in context. Maybe src or project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using settings in config to enable more.