Skip to content

Force locale setting for the script #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

ehrenfeu
Copy link
Contributor

@ehrenfeu ehrenfeu commented Mar 24, 2021

This avoids localized output that can confuse the script, e.g. when determining
the $defaultBranch.

We (as in @lguerard and me) were facing issues when trying to create a new
release using a fr_FR locale setting on Linux (Mint 20.1 / Ubuntu 20.04) as the
command for getting the default branch is failing there (the grep pattern doesn't
match on the french locale):

defaultBranch=$(git remote show "$remote" | grep "HEAD branch" | sed 's/.*: //')

PLEASE NOTE: this is entirely untested on MacOS and Windows, although
in my experience using the C locale should be supported there as well.

This avoids localized output that can confuse the script, e.g. when determining
the $defaultBranch.
@ctrueden
Copy link
Member

Thanks, @ehrenfeu! This change looks safe to me, so I'll go ahead and merge it.

@ctrueden ctrueden merged commit 23f5b57 into scijava:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants