Skip to content

Use pom.xml for repoSlug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Use pom.xml for repoSlug #14

merged 3 commits into from
Oct 27, 2017

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Oct 25, 2017

That prevents the script to pick up the wrong repository.

@ctrueden
Copy link
Member

@hadim Thanks very much for this!

It's late and I'm tired, but I could have sworn I commented that we probably also need --repo "$repoSlug" for the travis encrypt command. But now I don't see that comment here. And I see you did figure that out based on your chat messages. But there is no commit here yet doing that? If you add it (or amend the second commit to include that change), I'll merge it.

@hadim
Copy link
Contributor Author

hadim commented Oct 26, 2017

Here you are (forgot to push).

@@ -166,7 +166,7 @@ EOL
'#'*) continue;;
esac
info "Encrypting ${p%%=*}"
echo yes | $EXEC travis encrypt "$p" --add env.global
echo yes | $EXEC travis encrypt "$p" --add env.global --repo $repoSlug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I think the echo yes | is no longer necessary. I'll remove it in the following commit.

@ctrueden ctrueden merged commit 84cd8e4 into scijava:master Oct 27, 2017
@ctrueden
Copy link
Member

Thanks again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants