Skip to content

Commit 8372074

Browse files
committed
release-version.sh: remove obsolete GPG check
It looked for <releaseProfiles>sonatype-oss-release</releaseProfiles> in the <properties>. But the default for SciJava projects is now sonatype-oss-release, meaning if the releaseProfiles property is not explicitly set, it will try to release to Sonatype. So the test was not flagging projects configured to release to OSS Sonatype anyway. It is true that .travis/signingkey.asc.enc should be present for projects intended for release to OSS Sonatype, and if it is not, then the project will almost certainly fail to be released as intended. The release_version.sh script could check for this, but it does not check for similar prerequisites such as encrypted environment variable entries in the .travis.yml. So for now, let's not bother checking it.
1 parent 818b971 commit 8372074

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

release-version.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ valid_semver_bump () {
2020
sh -$- "$VALID_SEMVER_BUMP" "$@" || die
2121
}
2222

23-
verify_gpg_settings () {
24-
test "$SKIP_GPG" -o -f .travis/signingkey.asc.enc ||
25-
die 'GPG configuration not found. Please use travisify.sh to add it.
26-
See also: https://github.com/scijava/pom-scijava/wiki/GPG-Signing'
27-
}
28-
2923
verify_git_settings () {
3024
if [ ! "$SKIP_PUSH" ]
3125
then
@@ -113,10 +107,6 @@ valid_semver_bump "$pomVersion" "$VERSION"
113107
BASE_GAV="$(maven_helper gav-from-pom pom.xml)" ||
114108
die "Could not obtain GAV coordinates for base project"
115109

116-
# If releasing to OSS Sonatype, enable some extra stuff
117-
mvn -Dexec.executable='echo' -Dexec.args='${releaseProfiles}' exec:exec -q | grep -q 'sonatype-oss-release' &&
118-
verify_gpg_settings
119-
120110
git update-index -q --refresh &&
121111
git diff-files --quiet --ignore-submodules &&
122112
git diff-index --cached --quiet --ignore-submodules HEAD -- ||

0 commit comments

Comments
 (0)