-
Notifications
You must be signed in to change notification settings - Fork 12
Closed
Description
At the moment the v0.1.0 docs advocate that users use the action from main and not from a specific tag.
upload-nightly-action/README.md
Lines 10 to 17 in 80af44f
| jobs: | |
| steps: | |
| ... | |
| - name: Upload wheel | |
| uses: scientific-python/upload-nightly-action@main | |
| with: | |
| artifacts_path: dist | |
| anaconda_nightly_upload_token: ${{secrets.UPLOAD_TOKEN}} |
This seems like a security issue that should be avoided and that @webknjaz has discussed before for https://github.com/pypa/gh-action-pypi-publish.
A more secure option is to advocate that users use release tags and dependabot to check for updates to the GitHub Actions that they use and then consider from the PR if the update in the tag is something they are ready to accept. Example .github/dependabot.yml (taken from Scikit-HEP developer recommendations (thanks @henryiii!)):
version: 2
updates:
# Maintain dependencies for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"Metadata
Metadata
Assignees
Labels
No labels