Skip to content

Add information that pyi files are used in runtime when use attach_stub #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Mar 13, 2023

In this PR I try to clarify that attach_stub impacts not only type checking for IDE but also runtime.

closes #38

Czaki and others added 2 commits March 13, 2023 20:16
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #47 (563064d) into main (acbce79) will not change coverage.
The diff coverage is n/a.

❗ Current head 563064d differs from pull request most recent head f178c63. Consider uploading reports for the commit f178c63 to get more accurate results

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files           4        4           
  Lines         169      169           
=======================================
  Hits          153      153           
  Misses         16       16           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stefanv stefanv merged commit 43d6a63 into scientific-python:main Mar 13, 2023
@stefanv
Copy link
Member

stefanv commented Mar 13, 2023

Thanks @Czaki!

@Czaki Czaki deleted the update_readme branch March 13, 2023 19:23
@jarrodmillman jarrodmillman added this to the 0.2 milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to not fail on stub attach in frozen apps
3 participants