Merge pull request bremme#40 from berendkleinhaneveld/master

Fix compiler warnings

Author: bremme

README.md

@@ -82,7 +82,7 @@ If you use any of these super classes, you will also get all the basic, advanced
 * `snake()`                     Classic snake demo
 * `nightrider()`                Nightrider Kit demo
 * `bombTimer()`                 Count down a (bomb) timer
-* `bouchingBall()`              Bounching ball demo
+* `bouncingBall()`              Bouncing ball demo
 
 For more extended information on what arguments all above functions accept and return see the header files of the classes (SevenSegmentTM1637.h, SevenSegmentExtended.h and SevenSegmentFun.h).
 

examples/FunPrintAll/FunPrintAll.ino

@@ -45,10 +45,10 @@ void loop() {
   introDuceNextDemo("AUDIO VOLUME DEMO");
   audioVolume();
 
-  // bounchin ball
-  introDuceNextDemo("BOUNCHING BALL DEMO");
+  // bouncing ball
+  introDuceNextDemo("BOUNCING BALL DEMO");
   unsigned int numMoves = 100; unsigned int timeDelay = 100;
-  display.bouchingBall(numMoves, timeDelay);
+  display.bouncingBall(numMoves, timeDelay);
 
   // scrolling text
   introDuceNextDemo("SCROLLING TEXT DEMO");

library.properties

@@ -3,7 +3,7 @@ version=1.0.0
 author=Bram Harmsen <bramharmsen@gmail.com>
 maintainer=Bram Harmsen <bramharmsen@gmail.com>
 sentence=Library for using a 4 digit seven segment display with TM1636 or TM1637 driver IC
-paragraph=Extensive library for controlling a 4 digit seven segment display. This library inherent the Print class and uses the LCDAPI 1.0. For example you can use all normal Print methods like: print() and println(). From the LCDAPI among others begin(), clear(), home(), setCursor() and setBacklight() are implementend. On top of these regular functionality a segerate fun class which adds more features can be used. For example a bombtimer(), nightrider() and bounchingBall() method can be used when using the fun class.
+paragraph=Extensive library for controlling a 4 digit seven segment display. This library inherent the Print class and uses the LCDAPI 1.0. For example you can use all normal Print methods like: print() and println(). From the LCDAPI among others begin(), clear(), home(), setCursor() and setBacklight() are implementend. On top of these regular functionality a segerate fun class which adds more features can be used. For example a bombtimer(), nightrider() and bouncingBall() method can be used when using the fun class.
 category=Display
 url=https://github.com/bremme/arduino-tm1637
 architectures=avr

src/SevenSegmentFun.cpp

@@ -164,7 +164,7 @@ void  SevenSegmentFun::bombTimer(uint8_t hours, uint8_t min, uint16_t speed, cha
   blink();
 };
 
-void  SevenSegmentFun::bouchingBall(uint16_t moves, uint16_t d, bool runForever) {
+void  SevenSegmentFun::bouncingBall(uint16_t moves, uint16_t d, bool runForever) {
 
   int8_t wallRight  = TM1637_MAX_COLOM - 1;
   int8_t wallBottom = TM1637_MAX_LINES;
@@ -174,7 +174,7 @@ void  SevenSegmentFun::bouchingBall(uint16_t moves, uint16_t d, bool runForever)
   int8_t newX; int8_t newY;
   // default speed is 1 x right and 2 y down
   int8_t vx = 1; int8_t vy = 1;
-  bool flipVx; bool flipVy;
+  bool flipVx = false; bool flipVy = false;
 
   // print initial state
   printBall(x, y);

src/SevenSegmentFun.h

@@ -12,7 +12,7 @@
 
 // COMPILE TIME USER CONFIG ////////////////////////////////////////////////////
 #define  TM1637_SNAKE_DEFAULT_DELAY         50  // Snake step delay ms
-#define  TM1637_BOUNCH_BALL_DEFAULT_DELAY   100 // Bounching ball delay ms
+#define  TM1637_BOUNCING_BALL_DEFAULT_DELAY 100 // Bouncing ball delay ms
 #define  TM1637_NIGHTRIDER_DEFAULT_DELAY    200 // Nightrider delay ms
 //
 //        A
@@ -53,7 +53,7 @@ class SevenSegmentFun : public SevenSegmentExtended {
     void nightrider(uint8_t repeats = 10, uint16_t d = TM1637_NIGHTRIDER_DEFAULT_DELAY, uint8_t symbol = TM1637_CHAR_VERT_LEVEL);
     void bombTimer(uint8_t hours, uint8_t min, uint16_t speed = 60);
     void bombTimer(uint8_t hours, uint8_t min, uint16_t speed, char* str);
-    void bouchingBall(uint16_t moves, uint16_t d, bool runForever = false);
+    void bouncingBall(uint16_t moves, uint16_t d, bool runForever = false);
 
     void printBall(const int8_t x, const int8_t y);
     void print4Bit(const uint8_t x, const uint8_t y, uint8_t symbol);

src/SevenSegmentTM1637.cpp

@@ -134,18 +134,21 @@ SevenSegmentTM1637::SevenSegmentTM1637(uint8_t pinClk, uint8_t pinDIO) :
 size_t  SevenSegmentTM1637::write(uint8_t byte) {
   TM1637_DEBUG_PRINT(F("write byte:\t")); TM1637_DEBUG_PRINTLN(byte);
 
+  size_t n = 0;
   if ( _cursorPos == _numCols ) {
     shiftLeft(_rawBuffer, _numCols);
     _rawBuffer[_cursorPos] = encode( (char)byte );
     printRaw( _rawBuffer, _numCols, 0);
+    ++n;
   };
 
   if (_cursorPos < _numCols) {
     _rawBuffer[_cursorPos] = encode( (char)byte );
     printRaw( _rawBuffer, _cursorPos+1, 0);
     setCursor(1, _cursorPos + 1);
-  };
-
+    ++n;
+  }
+  return n;
 }
 
 // null terminated char array
@@ -164,6 +167,7 @@ size_t  SevenSegmentTM1637::write(const char* str) {
       break;
     }
   }
+  return i;
 };
 
 // byte array with length
@@ -177,6 +181,7 @@ size_t  SevenSegmentTM1637::write(const uint8_t* buffer, size_t size) {
   size_t length = encode(encodedBytes, buffer, size);
   TM1637_DEBUG_PRINT(F(" ")); TM1637_DEBUG_PRINTLN(encodedBytes[0], BIN);
   printRaw(encodedBytes,length, _cursorPos);
+  return length;
 };
 
 // Liquid cristal API
@@ -243,11 +248,15 @@ void SevenSegmentTM1637::setBacklight(uint8_t value) {
       cmd |= TM1637_SET_DISPLAY_ON | TM1637_SET_DISPLAY_14;
       break;
     };
+#if TM1637_DEBUG
     bool ack = command(cmd);
     TM1637_DEBUG_PRINT(F("SET_DISPLAY:\t")); TM1637_DEBUG_PRINTLN((
       cmd
     ), BIN);
     TM1637_DEBUG_PRINT(F("Acknowledged:\t")); TM1637_DEBUG_PRINTLN(ack);
+#else
+    command(cmd);
+#endif
 };
 
 void SevenSegmentTM1637::setContrast(uint8_t value) {
@@ -493,7 +502,7 @@ void    SevenSegmentTM1637::comStop(uint8_t pinClk, uint8_t pinDIO) {
 }
 
 bool    SevenSegmentTM1637::comAck(void) const {
-  comAck(_pinClk, _pinDIO);
+  return comAck(_pinClk, _pinDIO);
 };
 
 bool    SevenSegmentTM1637::comAck(uint8_t pinClk, uint8_t pinDIO) {

src/SevenSegmentTM1637.h

@@ -104,7 +104,7 @@ class SevenSegmentTM1637 : public Print {
 
 public:
   // LIQUID CRISTAL API ///////////////////////////////////////////////////////
-  /* See http://playground.arduino.cc/Code/LCDAPI for more details.
+  // See http://playground.arduino.cc/Code/LCDAPI for more details.
 
   /* Constructor
   @param [in] pinClk      clock pin (any digital pin)
@@ -121,7 +121,7 @@ class SevenSegmentTM1637 : public Print {
   /* Implemented for compatibility, see begin() above */
   void    begin(uint8_t cols = TM1637_MAX_COLOM, uint8_t rows = TM1637_MAX_LINES);
   // Print class inheritance ///////////////////////////////////////////////////
-  /* See https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/Print.h for more details
+  // See https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/Print.h for more details
   /* This library inherent the Print class, this means that all regular print function can be used. For example:
   * printing a number:                    print(78)
   * printint a number in BIN, OCT, HEX..: print(78, BIN)
@@ -235,7 +235,7 @@ class SevenSegmentTM1637 : public Print {
   *
   * For example to print an H, you would set bits BCEFG, this gives B01110110 in binary or 118 in decimal or 0x76 in HEX.
   * Bit 7 (X) only applies to the second digit and sets the colon
-  *
+  */
   /* Print raw (binary encodes) bytes to the display
   @param [in] rawBytes      Array of raw bytes
   @param [in] length        optional: length to print to display