Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push.js not found if not configured and logged in as admin + another issue #128

Open
valeriansaliou opened this issue Feb 13, 2021 · 0 comments

Comments

@valeriansaliou
Copy link

Hello there!

Thanks for Schnack, using it for my own Ghost blog. If it didn't exist I would have built it the same way, super happy you did it!

Just a quick issue report to let you know that, in my case I didn't configure web-push, and when I'm logged in as an admin there's a 404 to push.js which is still requested. Not happening for anonymous sessions AFAIK.

As well, another quick bug, I'm using the sendmail notifier, and the direct link to the comment in the email notifications is dangling, eg: Permalink: https://journal.valeriansaliou.name/announcing-sonic-a-super-light-alternative-to-elasticsearch/#comment-undefined (it's not passing the comment ID, but rather undefined).

Thanks for all!

@valeriansaliou valeriansaliou changed the title Push.js not found if not configured and logged in as admin Push.js not found if not configured and logged in as admin + another issue Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant