Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder attribute ignores non-default translation domain #367

Open
maria-p opened this issue Jun 8, 2016 · 2 comments
Open

Placeholder attribute ignores non-default translation domain #367

maria-p opened this issue Jun 8, 2016 · 2 comments
Labels
Milestone

Comments

@maria-p
Copy link

maria-p commented Jun 8, 2016

Q A
Bundle version 1.2.3
Symfony version 2.8.6
PHP version 7.0.7

I have form field like that:

$builder->add(
    'message',
    TextType::class,
    [
        'attr' => [
            'placeholder' => 'form.your_message'
        ],
        'translation_domain' => 'form',
        'label' => false
    ]
);

Translation is present in the specified domain, it is displayed properly, but when translation:extract is run, it marks that translation as missing.
With some debugging I found that it somehow gets parsed twice:

and second time it does not get the right domain passed.

@Nyholm Nyholm added the bug label Jun 12, 2016
@Nyholm Nyholm modified the milestone: 1.4.0 Aug 5, 2016
@jroussel
Copy link

Any news on this bug?

@gnat42
Copy link
Collaborator

gnat42 commented Jul 18, 2017

This package is barely maintained. If you have a PR I can review and tests pass I can merge it but I haven't had time to do much here for awhile and neither have the other maintainers unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants