Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS compatibility #7

Open
CelsoSantos opened this issue Mar 14, 2024 · 9 comments
Open

MacOS compatibility #7

CelsoSantos opened this issue Mar 14, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@CelsoSantos
Copy link

Hello,

I was able to checkout the project and compile and run it on a Mac (other than the tests project, which VS 2022 for Mac claims is incompatible).
I did have to make a couple changes (mostly changing ..\..\ like paths on the .csproj) and point a couple references to the correct place, but it builds and ruins.

Do you think it would be possible for you to also build/release for Mac? Can I help to achieve that goal in any way?

Thanks!

@CelsoSantos CelsoSantos changed the title MacOS version MacOS compatibility Mar 14, 2024
@BrenoAquino
Copy link

BrenoAquino commented Mar 15, 2024

That would be very interesting for me too. I was hoping you could release this plugin for Mac soon

@BrenoAquino
Copy link

@CelsoSantos how did you update the project to generate a build for macOS? I could build it, but even after the VS generates the plugin folder on the right place, Loupedesk is not showing the plugin for me

@schmic
Copy link
Owner

schmic commented Mar 15, 2024

Do you think it would be possible for you to also build/release for Mac? Can I help to achieve that goal in any way?

I'm sorry but no, as I don't have access to any Mac and therefor can't build the project.
I'd be happy to integrate some PRs for Mac support, if you want to provide them.

@CelsoSantos
Copy link
Author

@CelsoSantos how did you update the project to generate a build for macOS? I could build it, but even after the VS generates the plugin folder on the right place, Loupedesk is not showing the plugin for me

You probably just need to uncomment the yaml line relative to MacOS in the metadata file

@CelsoSantos
Copy link
Author

Do you think it would be possible for you to also build/release for Mac? Can I help to achieve that goal in any way?

I'm sorry but no, as I don't have access to any Mac and therefor can't build the project. I'd be happy to integrate some PRs for Mac support, if you want to provide them.

Let me have a look and see if I can do anything about it.. Honestly, setting it all up on MacOS wasn't the most pleasant experience, I'm not really sure of all the changes I did to get it working on VS for Mac, and my .NET days have passed quite a few years ago.

I'm thinking I might fork your repo and do my changes and then we can see if there's a way to "merge" the configs without breaking anything. I'll also have a look if there's anyway GH Actions can build for a Mac, but I somewhat doubt that part

@BrenoAquino
Copy link

I made it work locally on my mac, I didn't test it on a real device but the software loaded the plugin. The only thing that looked weird was that the software was showing the same image for both states (on and off). Unfortunately this is my first contact with c# / .net, I don't have much knowledge on it, but the code responsible to change the image looks right. Not sure if this is only a preview problem since I could not test on a real device

Also I could not run any tests, for some reason VS for Mac didn't accept those as @CelsoSantos said.

@schmic schmic added the enhancement New feature or request label Mar 20, 2024
@jsjohnstone
Copy link

@BrenoAquino any chance you documented what you changed/how you got it to build on Mac OS?

@jsjohnstone
Copy link

Worked it out - have added a PR (#14) which adds support for building on Mac OS X.

@schmic
Copy link
Owner

schmic commented Oct 12, 2024

Worked it out - have added a PR (#14) which adds support for building on Mac OS X.

Could you please review your PR#14 so it also compiles with the new project structure due to the Loupedeck 6.0 release? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants