Skip to content

File publisher support & tests #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

igrishaev
Copy link

As described in #10 , there is a pull-request to support File and Path body types. Tests added.

@igrishaev
Copy link
Author

Gentle ping? cc @schmee @borkdude

@borkdude
Copy link
Contributor

@igrishaev I'm not the maintainer of this lib, but babashka.http-client started of with pretty much the code from this library and has had this feature since a long time:

https://github.com/babashka/http-client/blob/c4071b0a0918f88f79e91b154a5b5c09129c7bb4/src/babashka/http_client/internal.clj#L216-L222

@igrishaev
Copy link
Author

@borkdude That's really great you have that bits in your client, that's good to know. But the company I'm working for at the moment has built everything on top of java-http-clj.

@igrishaev
Copy link
Author

@schmee ping?

@schmee
Copy link
Owner

schmee commented Jan 9, 2025

@igrishaev hey, sorry for the delay, I completely missed this PR in my feed!

I haven't been active in the Clojure community for a long time and I don't even know if I can figure out how to release a new version of this library, but I will try to figure it out and if so, merge this and release a new version.

For the future, if you need more features than this library provides, I would suggest to migrate to the http client by @borkdude since he is one of the all-time greats of Clojure and remains very active in the community 😄

@igrishaev
Copy link
Author

@schmee that's alright, there were NY/Christmas holidays anyway. Yes I have plans to migrate our stuff to babashka/http-client in the future. But still, if you merge this PR and make a new release, that would be great.

@igrishaev
Copy link
Author

Maybe this can help: in my project.clj files, I usually have this:

  :deploy-repositories
  {"releases"
   {:url "https://repo.clojars.org"
    :creds :gpg}
   "snapshots"
   {:url "https://repo.clojars.org"
    :creds :gpg}}

  :release-tasks
  [["vcs" "assert-committed"]
   ["test"]
   ["change" "version" "leiningen.release/bump-version" "release"]
   ["vcs" "commit"]
   ["vcs" "tag" "--no-sign"]
   ["deploy"]
   ["change" "version" "leiningen.release/bump-version"]
   ["vcs" "commit"]
   ["vcs" "push"]]

and then I just run lein release

@igrishaev
Copy link
Author

@schmee gentle reminder... can you please merge it and make a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants