Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add option to disable automatic grouping of private IPs #315

Open
schlagmichdoch opened this issue Jul 17, 2024 · 1 comment · May be fixed by #267
Open

[Enhancement] Add option to disable automatic grouping of private IPs #315

schlagmichdoch opened this issue Jul 17, 2024 · 1 comment · May be fixed by #267
Labels
enhancement New feature or request self-hosted

Comments

@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Jul 17, 2024

I'm trying to use PairDrop on an internal network that spans multiple 10.0.0.0/16 networks. X-Forwarded-For is correctly reporting the 10.x.y.z IP for clients, but ipIsPrivate assumes all private IPs are on the same network.

I don't know enough to suggest a good solution, but a good solution does seem difficult.

Just wanted to add my (hopefully not unique) use case for potential consideration.

Originally posted by @Skinner927 in #310 (comment)

We could solve this by adding an ENV VAR:

  • DETECT_PRIVATE_IPS:
    Specify whether all devices with private IPs should see each other mutually
    • DETECT_PRIVATE_IPS=false: Switch this off
    • DETECT_PRIVATE_IPS=true: Switch this on (default)

@Skinner927 Would this solve your issue? Devices would then only be able to find each other by pairing or entering the same public room. If your PairDrop instance is not reachable from the internet you could also take a look at the proposed ENV VAR to simply switch off grouping via IP: #301 (comment)

@schlagmichdoch schlagmichdoch added enhancement New feature or request self-hosted labels Jul 17, 2024
@Skinner927
Copy link

Yes, that would appear to solve it quite nicely.

@schlagmichdoch schlagmichdoch linked a pull request Aug 17, 2024 that will close this issue
60 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request self-hosted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants