Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Increase limit for sending to iPhones (200MB) by rewriting FileChunker / FileDigester #294

Open
schlagmichdoch opened this issue Apr 30, 2024 · 9 comments
Labels
enhancement New feature or request under development

Comments

@schlagmichdoch
Copy link
Owner

This issue was deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The creation date is unclear. There are also links to the deleted issue that are not updated to this issue. I decided to manually recreate it anyway in order to complete the information the repo holds even though the restored information might be outdated:

Issue by @schlagmichdoch:

Also another thing I wanted to point out. When using https://sharedrop.io (which is another website with a GitHub very similar to PairDrop) between an iOS & Android device, there is no 200MB limitation. With PairDrop is there a way to remove this like with ShareDrop? I tested it on this website and it worked fine with a file over 200MB. Both use WebRTC right? So would this be possible?

Originally posted by @Cohenl19 in #210 (comment)

See sharedrop.io and drop.lol

@schlagmichdoch
Copy link
Owner Author

schlagmichdoch commented Apr 30, 2024

The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:

Comment by @schlagmichdoch:

Also, do not just limit it by checking the OS as the memory limit is probably different on different devices (iPhone 8 has 2 GB of RAM - iPhone 15 has 8 GB of RAM). Is it possible to check the available memory dynamically?

Comment by @jayb-g:

There should definitely not be such a low file size limit or no limit at all especially on local network. Or high enough limit eg 5gb if, as pointed out by @schlagmichdoch websockets/webRTC is used and transfer can be chunked out. Auto pause-resume due to disconnection during a session would be a plus.

@schlagmichdoch
Copy link
Owner Author

@Cohenl19 @jayb-g I have an instance ready for testing that resolves this and increases transfer speed by quite a lot alongside many other things. Would you be open to testing it?

@jayb-g
Copy link

jayb-g commented Jul 15, 2024

@schlagmichdoch sure

@schlagmichdoch
Copy link
Owner Author

Great, thanks!

Instance: https://pairdrop-dev.onrender.com/
You can also install the PWA by opening the share menu and selecting "Add to Home".

Known issue:
When receiving a file on mobile, the filename is incorrect when using the share menu.

@jayb-g
Copy link

jayb-g commented Jul 15, 2024

@schlagmichdoch its still painstakingly slow. For a 138mb file it was showing 22mins time estimation. Did try same transfer using localsend and it transferred it in around 15-20secs showing 5MB/s speed

@jayb-g
Copy link

jayb-g commented Jul 15, 2024

Tried it directly from browser.

Trying again after adding it in URL in the app.

Edit: transferred the same file(138mb) using the app with the given instance. Transferred it in around 3mins.

Is there anything particularly done to improve speed than previous version? Speed seems to be very slow still. I'm not sure how it would fare on the default server pairdrop.net

Edit 2: it took twice the time with pairdrop.net as server. Almost 6 mins

@schlagmichdoch
Copy link
Owner Author

schlagmichdoch commented Jul 15, 2024

Thanks for testing!

Please do not use the Android app but rather the browser itself, as they inject their own file digester to save files directly on disk. I'll approach them after release. Also, disabling power savers might increase speed.

Sending a 1.5GB File from Ubuntu Firefox to iOS Safari on the same network got up to 15 MB/s for me.

Which browsers and OSs are you using.

@schlagmichdoch
Copy link
Owner Author

Also, as this issue is about size limit, could you try to send something bigger than 200MB to an iOS device to confirm everything is working for bigger files?

@jayb-g
Copy link

jayb-g commented Jul 16, 2024

@schlagmichdoch got it. Forgot to mention. I tested on Android chromium. Will test on Desktop browsers too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under development
Projects
None yet
Development

No branches or pull requests

2 participants