Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Pairdrop PWA makes itself the default text editor #116

Closed
ghost opened this issue May 28, 2023 · 4 comments
Closed

Bug: Pairdrop PWA makes itself the default text editor #116

ghost opened this issue May 28, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 28, 2023

Describe the bug
When pairdrop is installed as a PWA, it makes itself the default text editor.

To Reproduce
Steps to reproduce the behavior:

  1. Go to pairdrop
  2. Click on install it as PWA
  3. Open file manager and right click on a text file
  4. See error

Expected behavior
installing the PWA shouldn't replace the default app

Screenshots
Screenshot from 2023-05-28 11-12-12

Desktop (please complete the following information):

  • OS: Fedora 38 Gnome
  • Browser: Chromium
  • Version: Version 113.0.5672.126 (Official Build) Fedora Project (64-bit)

Self-Hosted
No

@ghost ghost changed the title Bug: Pairdrop P Bug: Pairdrop PWA makes itself the default text editor May 28, 2023
@schlagmichdoch
Copy link
Owner

This is similar to #17

It depends on the OS and the Browser how the file handler api is integrated. Some browsers allow to switch it off.
On the other hand, you just have to select the normal text editor as standard again and the problem is resolved.

Maybe we have to remove this API if this is annoying for many users.

@schlagmichdoch schlagmichdoch added the enhancement New feature or request label May 28, 2023
@ghost
Copy link
Author

ghost commented May 28, 2023

It would've been fine if it was only text files.
I've tested with many other file types and found out these file types are also affected:

  • pdf
  • every text file such as c, java, js, php, md
  • zip
  • penpot
  • apk
  • bin and many more
  • and it sets itself as the default calendar app

you just have to select the normal text editor as standard again and the problem is resolved.

There is no one click solution to set the default text editor graphically in Gnome at least.

@schlagmichdoch
Copy link
Owner

I'm afraid this behaviour cannot be changed. It seems the OS always sets the newest PWA as default for its filetypes.

You have two options:
Firstly, all default apps can be handled centrally under settings > default apps. If you have done it once you will never be bothered again as the OS always prefers the newer app.
Screenshot from 2023-05-30 10-25-16

Alternatively, you can go to chrome://apps on Google Chrome, right-click on PairDrop and select settings to get to the following menu. On the bottom you can switch off the File Handler Api completely. You can use the cli to send files instead.
Screenshot from 2023-05-30 10-29-08

Repository owner deleted a comment from schlagmichdoch Feb 17, 2024
@schlagmichdoch
Copy link
Owner

The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:

Comment by @schlagmichdoch:

This is fixed in version v1.10.0. The complete File Handling Api is removed as there have been too many incidents that it was rather annoying instead of helping. It is replaced by a way to use the pairdrop-cli script to send from the context menu on Windows and Linux: https://github.com/schlagmichdoch/PairDrop/blob/master/docs/how-to.md#send-multiple-files-and-directories-directly-from-context-menu-on-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant