Skip to content

Commit 0b52603

Browse files
Fix build issues with spaces and parentheses (earlephilhower#1136)
Add VERBATIM to add_custom_command Fixes earlephilhower#1043
1 parent 56594e7 commit 0b52603

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

src/rp2_common.cmake

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,20 @@
33
enable_language(ASM)
44

55
function(pico_add_hex_output TARGET)
6-
add_custom_command(TARGET ${TARGET} POST_BUILD COMMAND ${CMAKE_OBJCOPY} -Oihex $<TARGET_FILE:${TARGET}> $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.hex)
6+
add_custom_command(TARGET ${TARGET} POST_BUILD COMMAND ${CMAKE_OBJCOPY} -Oihex $<TARGET_FILE:${TARGET}> $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.hex
7+
VERBATIM)
78
endfunction()
89

910
function(pico_add_bin_output TARGET)
10-
add_custom_command(TARGET ${TARGET} POST_BUILD COMMAND ${CMAKE_OBJCOPY} -Obinary $<TARGET_FILE:${TARGET}> $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.bin)
11+
add_custom_command(TARGET ${TARGET} POST_BUILD COMMAND ${CMAKE_OBJCOPY} -Obinary $<TARGET_FILE:${TARGET}> $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.bin
12+
VERBATIM)
1113
endfunction()
1214

1315
function(pico_add_dis_output TARGET)
1416
add_custom_command(TARGET ${TARGET} POST_BUILD
15-
COMMAND ${CMAKE_OBJDUMP} -h $<TARGET_FILE:${TARGET}> >$<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.dis
16-
COMMAND ${CMAKE_OBJDUMP} -d $<TARGET_FILE:${TARGET}> >>$<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.dis
17-
)
17+
COMMAND ${CMAKE_OBJDUMP} -h $<TARGET_FILE:${TARGET}> > $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.dis
18+
COMMAND ${CMAKE_OBJDUMP} -d $<TARGET_FILE:${TARGET}> >> $<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.dis
19+
VERBATIM)
1820
endfunction()
1921

2022
function(pico_add_extra_outputs TARGET)

src/rp2_common/boot_stage2/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,13 @@ function(pico_define_boot_stage2 NAME SOURCES)
6363
find_package (Python3 REQUIRED COMPONENTS Interpreter)
6464

6565
add_custom_target(${NAME}_bin DEPENDS ${ORIGINAL_BIN})
66-
add_custom_command(OUTPUT ${ORIGINAL_BIN} DEPENDS ${NAME} COMMAND ${CMAKE_OBJCOPY} -Obinary $<TARGET_FILE:${NAME}> ${ORIGINAL_BIN})
66+
add_custom_command(OUTPUT ${ORIGINAL_BIN} DEPENDS ${NAME} COMMAND ${CMAKE_OBJCOPY} -Obinary $<TARGET_FILE:${NAME}> ${ORIGINAL_BIN}
67+
VERBATIM)
6768

6869
add_custom_target(${NAME}_padded_checksummed_asm DEPENDS ${PADDED_CHECKSUMMED_ASM})
6970
add_custom_command(OUTPUT ${PADDED_CHECKSUMMED_ASM} DEPENDS ${ORIGINAL_BIN}
7071
COMMAND ${Python3_EXECUTABLE} ${PICO_BOOT_STAGE2_DIR}/pad_checksum -s 0xffffffff ${ORIGINAL_BIN} ${PADDED_CHECKSUMMED_ASM}
71-
)
72+
VERBATIM)
7273

7374
add_library(${NAME}_library INTERFACE)
7475
add_dependencies(${NAME}_library ${NAME}_padded_checksummed_asm)

src/rp2_common/cyw43_driver/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ if (EXISTS ${PICO_CYW43_DRIVER_PATH}/${CYW43_DRIVER_TEST_FILE})
5858
--redefine-sym _binary_${CYW43_FIRMWARE_BIN_}_end=${CYW43_FIRMWARE_PRETTY}_end
5959
--redefine-sym _binary_${CYW43_FIRMWARE_BIN_}_size=${CYW43_FIRMWARE_PRETTY}_size
6060
${CYW43_FIRMWARE_BIN} ${CYW43_FIRMWARE_OBJ}
61-
)
61+
VERBATIM)
6262

6363
add_library(cyw43_driver_picow INTERFACE)
6464
target_sources(cyw43_driver_picow INTERFACE

tools/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function(pico_generate_pio_header TARGET PIO)
3333
add_custom_command(OUTPUT ${HEADER}
3434
DEPENDS ${PIO}
3535
COMMAND Pioasm -o ${OUTPUT_FORMAT} ${PIO} ${HEADER}
36-
)
36+
VERBATIM)
3737
add_dependencies(${TARGET} ${HEADER_GEN_TARGET})
3838
get_target_property(target_type ${TARGET} TYPE)
3939
if ("INTERFACE_LIBRARY" STREQUAL "${target_type}")
@@ -59,6 +59,7 @@ function(pico_add_uf2_output TARGET)
5959
endif()
6060
if (ELF2UF2_FOUND)
6161
add_custom_command(TARGET ${TARGET} POST_BUILD
62-
COMMAND ELF2UF2 $<TARGET_FILE:${TARGET}> ${output_path}$<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.uf2)
62+
COMMAND ELF2UF2 $<TARGET_FILE:${TARGET}> ${output_path}$<IF:$<BOOL:$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>>,$<TARGET_PROPERTY:${TARGET},OUTPUT_NAME>,$<TARGET_PROPERTY:${TARGET},NAME>>.uf2
63+
VERBATIM)
6364
endif()
6465
endfunction()

0 commit comments

Comments
 (0)