Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractNavitiaProvider: use full url for TripQuery #275

Closed
ialokim opened this issue Jul 21, 2019 · 5 comments
Closed

AbstractNavitiaProvider: use full url for TripQuery #275

ialokim opened this issue Jul 21, 2019 · 5 comments

Comments

@ialokim
Copy link
Contributor

ialokim commented Jul 21, 2019

As pointed out (some time ago) in this issue, AbstractNavitiaProvider does not add coverage information into the url when searching for a trip (on endpoint journeys), see here.

This does not cause any problems when there is no error as Navitia can handle queries without the coverage part. But in the case of an invalid station, it seems to make a difference: Navitia's returning a BlockedException instead of the invalid_station flag.

I guess this could be solved by simply adding the coverage part into the url as done in all the other methods (e.g. suggestLocations). They use the method url() which returns the base path including the coverage.

If you want me to do so, I could make the necessary change and open an PR.

@grote
Copy link
Contributor

grote commented Jul 22, 2019

I think we should add the coverage info to the URL.

@ialokim
Copy link
Contributor Author

ialokim commented Jul 25, 2019

(pinging @aelkhour and @schildbach for comments as they seem to be the main authors of this NetworkProvider)

@ialokim
Copy link
Contributor Author

ialokim commented Jan 2, 2020

Some thoughts on this @schildbach ?

@schildbach
Copy link
Owner

I'm not an expert on the Navitia API. From your description, it sounds like a reasonable thing to do. Feel free to submit a PR.

@schildbach
Copy link
Owner

Fixed via #295.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants