-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractNavitiaProvider: use full url for TripQuery #275
Comments
I think we should add the coverage info to the URL. |
(pinging @aelkhour and @schildbach for comments as they seem to be the main authors of this NetworkProvider) |
Some thoughts on this @schildbach ? |
I'm not an expert on the Navitia API. From your description, it sounds like a reasonable thing to do. Feel free to submit a PR. |
Fixed via #295. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As pointed out (some time ago) in this issue,
AbstractNavitiaProvider
does not addcoverage
information into the url when searching for a trip (on endpointjourneys
), see here.This does not cause any problems when there is no error as Navitia can handle queries without the
coverage
part. But in the case of an invalid station, it seems to make a difference: Navitia's returning aBlockedException
instead of theinvalid_station
flag.I guess this could be solved by simply adding the
coverage
part into the url as done in all the other methods (e.g.suggestLocations
). They use the methodurl()
which returns the base path including thecoverage
.If you want me to do so, I could make the necessary change and open an PR.
The text was updated successfully, but these errors were encountered: