Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Quotes around exact terms do not affect in-file search #336

Closed
sngchn85 opened this issue Jan 1, 2024 · 1 comment
Closed

[BUG] Quotes around exact terms do not affect in-file search #336

sngchn85 opened this issue Jan 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sngchn85
Copy link

sngchn85 commented Jan 1, 2024

Problem description:

When searching for an exact term in quotes, the vault search successfully filters down the notes it displays to only those that contain the exact search. However, the in-file search (whether selected to begin with or switched to from vault search) seems to behave exactly the same as if there are no quotes. Specifically, all tokens in the file that begin with any of the words included in the exact search match and are shown.

Here's an example screenshot:
image

And a screenshot of the associated logs:
image

Your environment:

  • Omnisearch version: 1.20.2
  • Obsidian version: 1.5.3
  • Operating system: Microsoft Windows 11 Home 10.0.22621 Build 22621
  • Number of indexed documents in your vault (approx.): 850

Things to try:

  • Does the problem occur when Omnisearch is the only active community plugin: Yes
  • Does the problem occur when you don't index PDFs, images, or other non-notes files: Yes
  • Does the problem occur after a cache reset: Yes
@scambier scambier added the bug Something isn't working label Jan 1, 2024
@sngchn85 sngchn85 changed the title [BUG] Quotes around exact terms do not affect in-file search #335 [BUG] Quotes around exact terms do not affect in-file search Jan 1, 2024
@Drakemoor
Copy link

I'm on
Omnisearch version: 1.21.1
Obsidian version: 1.5.8

This bug still exists. For this reason, I often have to switch back to the native Obsidian search to find what I'm looking for. It would be nice if we didn't need to juggle.

Thank you for your consideration.

@scambier scambier added the ready to ship Fixed and will be deployed in next (beta) release label Feb 23, 2024
@scambier scambier removed the ready to ship Fixed and will be deployed in next (beta) release label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants