Skip to content

Commit 82203d5

Browse files
munna-shaik-s1munna-shaik-s1
authored
[MAPPS-2235] fix: Splunk app inspect issue fix (#139)
* [MAPPS-2235] fix: TA splunk app inspect issue fix * [MAPPS-2235] fix: TA splunk app ui updation
1 parent 204129e commit 82203d5

File tree

5 files changed

+24
-72
lines changed

5 files changed

+24
-72
lines changed

‎TA_dataset/README.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# TA_dataset
22
This add-on integrates with [DataSet](https://www.dataset.com) and [Singularity Data Lake](https://www.sentinelone.com/platform/xdr-ingestion) by [SentinelOne](https://www.sentinelone.com).
33

4+
5+
# Binary File Declaration
6+
lib/charset_normalizer/md.cpython-38-x86_64-linux-gnu.so: This binary file is provided along with charset_normalizer module and source code for the same can be found at https://pypi.org/project/charset-normalizer/
7+
lib/charset_normalizer/md__mypyc.cpython-38-x86_64-linux-gnu.so: This binary file is provided along with charset_normalizer module and source code for the same can be found at https://pypi.org/project/charset-normalizer/
8+
9+
410
For more information, see the [GitHub](https://github.com/scalyr/dataset-addon-for-splunk) repository.
511
##### Note
612
This add-on was built with the [Splunk Add-on UCC framework](https://splunk.github.io/addonfactory-ucc-generator/).

‎e2e/global.setup.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ setup('login and create account', async ({ page }) => {
5656
await locAddDialog.click();
5757

5858
// Setup locators
59-
const locAccount = page.locator('div').filter({ hasText: /^\*?Account Name \*Enter a unique name for this account\.$/ }).locator('[data-test="textbox"]')
60-
const locUrl = page.locator('div').filter({ hasText: /^\*?URL \*Enter DataSet URL\.$/ }).locator('[data-test="textbox"]')
59+
const locAccount = page.locator('div').filter({ hasText: /^\*?Account NameEnter a unique name for this account\.$/ }).locator('[data-test="textbox"]')
60+
const locUrl = page.locator('div').filter({ hasText: /^\*?URLEnter DataSet URL\.$/ }).locator('[data-test="textbox"]')
6161
const locReadKey = page.locator('[data-test="body"] form div').filter({ hasText: 'SDL Read Access Key (Legacy)Required (if no AuthN token provided) to enable' }).locator('[data-test="textbox"]');
6262
const locWriteKey = page.locator('[data-test="body"] form div').filter({ hasText: 'SDL Write Access Key (Legacy)Required (if no AuthN token provided) to enable alert action.' }).locator('[data-test="textbox"]');
6363

‎e2e/inputs.spec.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test('New Input - DataSet Query', async ({ page }) => {
2323
await page.locator('div').filter({ hasText: /^\*?ColumnsIf left blank, all columns are returned\.$/ }).locator('[data-test="textbox"]').fill("")
2424
await page.locator('form div').filter({ hasText: /^\*?Max CountSpecifies the maximum number of records to return. If left blank, the d/ }).locator('[data-test="textbox"]').fill("13")
2525

26-
await page.getByLabel("Select a value").click();
26+
await page.getByLabel("Select...").click();
2727
await page.locator('[data-test="option"]').first().click();
2828

2929
await page.screenshot({ path: 'playwright-screenshots/page-inputs-query-01-filled-form.png', fullPage: true });
@@ -50,7 +50,7 @@ test('New Input - DataSet PowerQuery', async ({ page }) => {
5050
await page.locator('form div').filter({ hasText: /^\*?End TimeIf left blank, present time at query execution is used. If defined, use/ }).locator('[data-test="textbox"]').fill("1m")
5151
await page.locator('form div').filter({ hasText: /^\*?DataSet PowerQuery String/ }).locator('[data-test="textbox"]').fill("serverHost=* | group count=count() by tag")
5252

53-
await page.getByLabel("Select a value").click();
53+
await page.getByLabel("Select...").click();
5454
await page.locator('[data-test="option"]').first().click();
5555

5656
await page.screenshot({ path: 'playwright-screenshots/page-inputs-powerquery-01-filled-form.png', fullPage: true });
@@ -77,7 +77,7 @@ test('New Input - DataSet Alerts', async ({ page }) => {
7777
await page.locator('div').filter({ hasText: /^\*?IntervalTime interval of input in seconds\.$/ }).locator('[data-test="textbox"]').fill("20")
7878
await page.locator('form div').filter({ hasText: /^\*?Start TimeRelative time to query back. Use short form relative time, e.g.: 24h/ }).locator('[data-test="textbox"]').fill("60m")
7979

80-
await page.getByLabel("Select a value").click();
80+
await page.getByLabel("Select...").click();
8181
await page.locator('[data-test="option"]').first().click();
8282

8383
await page.screenshot({ path: 'playwright-screenshots/page-inputs-alerts-01-filled-form.png', fullPage: true });

‎globalConfig.json‎

Lines changed: 12 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
"displayName": "Singularity Data Lake Add-On for Splunk",
55
"version": "2.0.71-SNAPSHOT",
66
"restRoot": "TA_dataset",
7-
"schemaVersion": "0.0.3"
7+
"schemaVersion": "0.0.7",
8+
"_uccVersion": "5.47.0"
89
},
910
"pages": {
1011
"configuration": {
@@ -34,7 +35,7 @@
3435
"entity": [
3536
{
3637
"field": "name",
37-
"label": "Account Name *",
38+
"label": "Account Name",
3839
"type": "text",
3940
"required": true,
4041
"help": "Enter a unique name for this account.",
@@ -54,7 +55,7 @@
5455
},
5556
{
5657
"field": "url",
57-
"label": "URL *",
58+
"label": "URL",
5859
"type": "text",
5960
"help": "Enter DataSet URL.",
6061
"required": true,
@@ -69,7 +70,7 @@
6970
},
7071
{
7172
"field": "tenant",
72-
"label": "Run On *",
73+
"label": "Run On",
7374
"type": "singleSelect",
7475
"options": {
7576
"disableSearch": true,
@@ -186,41 +187,7 @@
186187
]
187188
},
188189
{
189-
"name": "logging",
190-
"title": "Logging",
191-
"entity": [
192-
{
193-
"field": "loglevel",
194-
"label": "Log level",
195-
"type": "singleSelect",
196-
"options": {
197-
"disableSearch": true,
198-
"autoCompleteFields": [
199-
{
200-
"label": "DEBUG",
201-
"value": "DEBUG"
202-
},
203-
{
204-
"label": "INFO",
205-
"value": "INFO"
206-
},
207-
{
208-
"label": "WARNING",
209-
"value": "WARNING"
210-
},
211-
{
212-
"label": "ERROR",
213-
"value": "ERROR"
214-
},
215-
{
216-
"label": "CRITICAL",
217-
"value": "CRITICAL"
218-
}
219-
]
220-
},
221-
"defaultValue": "INFO"
222-
}
223-
]
190+
"type": "loggingTab"
224191
},
225192
{
226193
"name": "proxy",
@@ -398,18 +365,11 @@
398365
}
399366
},
400367
{
368+
"type": "interval",
401369
"field": "interval",
402370
"label": "Interval",
403-
"type": "text",
404-
"required": true,
405371
"help": "Time interval of input in seconds.",
406-
"validators": [
407-
{
408-
"type": "regex",
409-
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
410-
"errorMsg": "Interval must be an integer."
411-
}
412-
]
372+
"required": true
413373
},
414374
{
415375
"field": "index",
@@ -561,18 +521,11 @@
561521
}
562522
},
563523
{
524+
"type": "interval",
564525
"field": "interval",
565526
"label": "Interval",
566-
"type": "text",
567-
"required": true,
568527
"help": "Time interval of input in seconds.",
569-
"validators": [
570-
{
571-
"type": "regex",
572-
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
573-
"errorMsg": "Interval must be an integer."
574-
}
575-
]
528+
"required": true
576529
},
577530
{
578531
"field": "index",
@@ -687,18 +640,11 @@
687640
}
688641
},
689642
{
643+
"type": "interval",
690644
"field": "interval",
691645
"label": "Interval",
692-
"type": "text",
693-
"required": true,
694646
"help": "Time interval of input in seconds.",
695-
"validators": [
696-
{
697-
"type": "regex",
698-
"pattern": "^\\-[1-9]\\d*$|^\\d*$",
699-
"errorMsg": "Interval must be an integer."
700-
}
701-
]
647+
"required": true
702648
},
703649
{
704650
"field": "index",

‎requirements-pack.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ cython<3.0.0; python_version <= '3.8'
44
# we use 3.8 for development
55
pip==23.2.1; python_version <= '3.8'
66
pyyaml==6.0.1; python_version <= '3.8'
7-
splunk-add-on-ucc-framework==5.13.2; python_version <= '3.8'
7+
splunk-add-on-ucc-framework==5.47.0; python_version <= '3.8'
88
splunk-appinspect==2.37.2; python_version <= '3.8'
99
wheel==0.41.0; python_version <= '3.8'

0 commit comments

Comments
 (0)