-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if GC config exists before creating gc producer in replication #2555
base: development/8.7
Are you sure you want to change the base?
Check if GC config exists before creating gc producer in replication #2555
Conversation
Hello killiang,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
@@ Coverage Diff @@
## development/8.7 #2555 +/- ##
===================================================
- Coverage 69.58% 69.57% -0.01%
===================================================
Files 194 194
Lines 12822 12826 +4
===================================================
+ Hits 8922 8924 +2
- Misses 3890 3892 +2
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. |
extensions/replication/replicationStatusProcessor/ReplicationStatusProcessor.js
Outdated
Show resolved
Hide resolved
extensions/replication/replicationStatusProcessor/ReplicationStatusProcessor.js
Outdated
Show resolved
Hide resolved
if (this.gcConfig) { | ||
this._gcProducer = new GarbageCollectorProducer(); | ||
return this._gcProducer.setupProducer(done); | ||
} else { | ||
return done(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add tests for this
Co-authored-by: William <91462779+williamlardier@users.noreply.github.com>
Issue: BB-569