Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if GC config exists before creating gc producer in replication #2555

Open
wants to merge 5 commits into
base: development/8.7
Choose a base branch
from

Conversation

KillianG
Copy link
Contributor

Issue: BB-569

@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Oct 15, 2024
@bert-e
Copy link
Contributor

bert-e commented Oct 15, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.57%. Comparing base (93d499f) to head (aac0262).
Report is 2 commits behind head on development/8.7.

Files with missing lines Patch % Lines
...ationStatusProcessor/ReplicationStatusProcessor.js 80.00% 1 Missing ⚠️
...ons/replication/replicationStatusProcessor/task.js 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
...ationStatusProcessor/ReplicationStatusProcessor.js 67.70% <80.00%> (-0.02%) ⬇️
...ons/replication/replicationStatusProcessor/task.js 0.00% <0.00%> (ø)
Components Coverage Δ
Bucket Notification 66.66% <ø> (ø)
Core Library 74.12% <ø> (ø)
Ingestion 69.24% <ø> (ø)
Lifecycle 75.47% <ø> (ø)
Oplog Populator 82.95% <ø> (ø)
Replication 57.41% <66.66%> (-0.02%) ⬇️
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/8.7    #2555      +/-   ##
===================================================
- Coverage            69.58%   69.57%   -0.01%     
===================================================
  Files                  194      194              
  Lines                12822    12826       +4     
===================================================
+ Hits                  8922     8924       +2     
- Misses                3890     3892       +2     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.63% <0.00%> (-0.01%) ⬇️
api:routes 9.53% <0.00%> (-0.01%) ⬇️
bucket-scanner 85.76% <ø> (ø)
ingestion 12.47% <0.00%> (-0.01%) ⬇️
lib 7.52% <0.00%> (-0.01%) ⬇️
lifecycle 19.50% <0.00%> (-0.01%) ⬇️
notification 0.88% <0.00%> (-0.01%) ⬇️
replication 18.92% <66.66%> (+<0.01%) ⬆️
unit 43.95% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Comment on lines +375 to +380
if (this.gcConfig) {
this._gcProducer = new GarbageCollectorProducer();
return this._gcProducer.setupProducer(done);
} else {
return done();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add tests for this

KillianG and others added 2 commits October 15, 2024 15:07
Co-authored-by: William <91462779+williamlardier@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants