From 2f5501485cc32aec6479cd4f819b4241835a9348 Mon Sep 17 00:00:00 2001
From: Maha Benzekri <maha.benzekri@scality.com>
Date: Mon, 7 Oct 2024 21:32:40 +0200
Subject: [PATCH] fixup post review

---
 monitoring/mongodb/alerts.test.yaml | 5 +++++
 monitoring/mongodb/alerts.yaml      | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/monitoring/mongodb/alerts.test.yaml b/monitoring/mongodb/alerts.test.yaml
index 75ab0d026..47aa1ec46 100644
--- a/monitoring/mongodb/alerts.test.yaml
+++ b/monitoring/mongodb/alerts.test.yaml
@@ -345,6 +345,10 @@ tests:
         values: 2x10
       - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-1", member_state="SECONDARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-2.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
         values: 2x10
+      - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-2", member_state="PRIMARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-2.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
+        values: 1x10
+      - series: mongodb_rs_members_state{namespace="zenko", pod="data-db-mongodb-sharded-shard0-data-2", member_state="SECONDARY", rs_nm="data-db-mongodb-sharded-shard-0", rs_state="1", member_idx="data-db-mongodb-sharded-shard0-data-1.data-db-mongodb-sharded-headless.zenko.svc.cluster.local:27017"}
+        values: 2x10
 
     alert_rule_test:
       - alertname: MongoDbRSNotSynced
@@ -353,6 +357,7 @@ tests:
           - exp_labels:
               severity: warning
               rs_nm: data-db-mongodb-sharded-shard-0
+              pod: data-db-mongodb-sharded-shard0-data-2
             exp_annotations:
               description: "MongoDB replica set `data-db-mongodb-sharded-shard-0` is not in the expected state. It currently has `1` SECONDARY members instead of the expected number. Please ensure that all instances are running properly."
               summary: MongoDB replica set out of sync
\ No newline at end of file
diff --git a/monitoring/mongodb/alerts.yaml b/monitoring/mongodb/alerts.yaml
index be53053a6..90cce244a 100644
--- a/monitoring/mongodb/alerts.yaml
+++ b/monitoring/mongodb/alerts.yaml
@@ -183,7 +183,7 @@ groups:
 
   - alert: MongoDbRSNotSynced
     expr: |
-      count by (rs_nm, pod) (mongodb_rs_members_state{namespace="${namespace}", pod=~"${service}.*", member_state="SECONDARY", rs_state="1"}) != 0
+      count by (rs_nm, pod) (mongodb_rs_members_state{namespace="${namespace}", pod=~"${service}.*", member_state="SECONDARY", rs_state="1"}) != (${replicas} - 1)
     for: 10m
     labels:
       severity: warning