Skip to content

Commit 4ef5748

Browse files
author
Will Toozs
committed
fixup: conditions in routesPOST
1 parent 9e824e2 commit 4ef5748

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

lib/s3routes/routes/routePOST.ts

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,18 @@ export default function routePOST(
5858
corsHeaders));
5959
}
6060

61+
if (objectKey && Object.keys(query).length !== 0) {
62+
return routesUtils.responseNoBody(errors.MethodNotAllowed, null, response, 405, log);
63+
}
64+
6165
if (objectKey === undefined) {
62-
if (Object.keys(query).length > 0) {
63-
return routesUtils.responseNoBody(errors.InvalidArgument
64-
.customizeDescription("Query String Parameters not allowed on POST requests."), null,
65-
response, 400, log);
66-
}
67-
return api.callPostObject('objectPost', request, response, log, (err, resHeaders) => routesUtils.responseNoBody(err, resHeaders, response, 204, log));
66+
// Handle invalid query string parameters
67+
if (Object.keys(query).length > 0) {
68+
return routesUtils.responseNoBody(errors.InvalidArgument
69+
.customizeDescription("Query String Parameters not allowed on POST requests."), null, response, 400, log);
70+
}
71+
return api.callPostObject('objectPost', request, response, log, (err, resHeaders) =>
72+
routesUtils.responseNoBody(err, resHeaders, response, 204, log));
6873
}
6974

7075
return routesUtils.responseNoBody(errors.NotImplemented, null, response,

0 commit comments

Comments
 (0)