Skip to content

Conversation

@iManu
Copy link
Contributor

@iManu iManu commented Sep 8, 2025

Summary

Need to add the :root in addition to :root.classname for some use cases, when we do not need to add the class in html tag for sites that does not have multiple themes

Type

  • Enhancement

Summarise concisely:

  • add simple :root selector on generated css

What is expected?

  • It should enable usage of css variable without the need of adding the classname to html tag

The following changes where made:

(Describe what you did)

  1. update create-css-variables.tsx

Need to add the `:root` in addition to `:root.classname` for some use cases, when we do not need to add the class in html tag for sites that does not have multiple themes
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: 797f697

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@ultraviolet/themes Minor
@ultraviolet/form Patch
@ultraviolet/icons Patch
@ultraviolet/illustrations Patch
@ultraviolet/plus Patch
@ultraviolet/ui Patch
@ultraviolet/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.48%. Comparing base (59dd42c) to head (797f697).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5513   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files         228      228           
  Lines        8131     8131           
  Branches     3509     3560   +51     
=======================================
  Hits         7520     7520           
  Misses        611      611           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6716e...797f697. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iManu iManu requested a review from philibea September 8, 2025 15:29
@iManu iManu merged commit 4439df6 into main Sep 9, 2025
15 checks passed
@iManu iManu deleted the iManu-patch-1 branch September 9, 2025 07:12
This was referenced Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants