Skip to content

fix(menuV2): search text prop #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

fix(menuV2): search text prop #5213

wants to merge 2 commits into from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Add props searchText on MenuV2 and add limitation on searchable of this component.

@matthprost matthprost self-assigned this Jun 5, 2025
@matthprost matthprost requested review from a team, johnrazeur and lisalupi as code owners June 5, 2025 12:55
@matthprost matthprost added the enhancement New feature or request label Jun 5, 2025
Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: 4eebc9a

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (beta@11f7672). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #5213   +/-   ##
=======================================
  Coverage        ?   88.88%           
=======================================
  Files           ?      237           
  Lines           ?     8415           
  Branches        ?     3795           
=======================================
  Hits            ?     7480           
  Misses          ?      935           
  Partials        ?        0           
Files with missing lines Coverage Δ
...kages/ui/src/components/MenuV2/components/Item.tsx 86.66% <ø> (ø)
packages/ui/src/components/MenuV2/helpers.ts 94.11% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f7672...4eebc9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants