fix(core): total_count legacy #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laure-di
force-pushed
the
fix/total-count
branch
from
7d3bebe to
116dc62
Compare
Codelax
reviewed
Jul 12, 2024
| @@ -168,6 +166,12 @@ def _request( | |||
| verify=not self.client.api_allow_insecure, | |||
| ) | |||
|
|
|||
| if response.headers.get("x-total-count"): | |||
There was a problem hiding this comment.
Can we have tests for it ? We can use listServerTypes as it does not require a token.
Laure-di
force-pushed
the
fix/total-count
branch
2 times, most recently
from
a9a4dd8 to
f06b3c8
Compare
Laure-di
force-pushed
the
fix/total-count
branch
from
f06b3c8 to
8d55476
Compare
|
Hi ! |
remyleone
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #555
close #550