Skip to content

Commit 2d06983

Browse files
authored
fix(instance): change two types as nullable (#6)
1 parent 03b4470 commit 2d06983

File tree

4 files changed

+14
-22
lines changed

4 files changed

+14
-22
lines changed

scaleway-async/scaleway_async/instance/v1/api.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,15 +1025,15 @@ async def get_image(
10251025
async def create_image(
10261026
self,
10271027
root_volume: str,
1028-
default_bootscript: str,
1029-
public: bool,
10301028
zone: Optional[Zone] = None,
10311029
name: Optional[str] = None,
10321030
arch: Arch = Arch.X86_64,
1031+
default_bootscript: Optional[str] = None,
10331032
extra_volumes: Optional[Dict[str, VolumeTemplate]] = None,
10341033
organization: Optional[str] = None,
10351034
project: Optional[str] = None,
10361035
tags: Optional[List[str]] = None,
1036+
public: Optional[bool] = None,
10371037
) -> CreateImageResponse:
10381038
"""
10391039
Create an instance image
@@ -1056,11 +1056,7 @@ async def create_image(
10561056
Usage:
10571057
::
10581058
1059-
result = await api.create_image(
1060-
root_volume="example",
1061-
default_bootscript="example",
1062-
public=True,
1063-
)
1059+
result = await api.create_image(root_volume="example")
10641060
"""
10651061

10661062
param_zone = validate_path_param("zone", zone or self.client.default_zone)
@@ -1071,15 +1067,15 @@ async def create_image(
10711067
body=marshal_CreateImageRequest(
10721068
CreateImageRequest(
10731069
root_volume=root_volume,
1074-
default_bootscript=default_bootscript,
1075-
public=public,
10761070
zone=zone,
10771071
name=name or random_name(prefix="img"),
10781072
arch=arch,
1073+
default_bootscript=default_bootscript,
10791074
extra_volumes=extra_volumes,
10801075
organization=organization,
10811076
project=project,
10821077
tags=tags,
1078+
public=public,
10831079
),
10841080
self.client,
10851081
),

scaleway-async/scaleway_async/instance/v1/types.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,7 +2036,7 @@ class CreateImageRequest:
20362036
Architecture of the image
20372037
"""
20382038

2039-
default_bootscript: str
2039+
default_bootscript: Optional[str]
20402040
"""
20412041
Default bootscript of the image
20422042
"""
@@ -2066,7 +2066,7 @@ class CreateImageRequest:
20662066
The tags of the image
20672067
"""
20682068

2069-
public: bool
2069+
public: Optional[bool]
20702070
"""
20712071
True to create a public image
20722072
"""

scaleway/scaleway/instance/v1/api.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,15 +1025,15 @@ def get_image(
10251025
def create_image(
10261026
self,
10271027
root_volume: str,
1028-
default_bootscript: str,
1029-
public: bool,
10301028
zone: Optional[Zone] = None,
10311029
name: Optional[str] = None,
10321030
arch: Arch = Arch.X86_64,
1031+
default_bootscript: Optional[str] = None,
10331032
extra_volumes: Optional[Dict[str, VolumeTemplate]] = None,
10341033
organization: Optional[str] = None,
10351034
project: Optional[str] = None,
10361035
tags: Optional[List[str]] = None,
1036+
public: Optional[bool] = None,
10371037
) -> CreateImageResponse:
10381038
"""
10391039
Create an instance image
@@ -1056,11 +1056,7 @@ def create_image(
10561056
Usage:
10571057
::
10581058
1059-
result = api.create_image(
1060-
root_volume="example",
1061-
default_bootscript="example",
1062-
public=True,
1063-
)
1059+
result = api.create_image(root_volume="example")
10641060
"""
10651061

10661062
param_zone = validate_path_param("zone", zone or self.client.default_zone)
@@ -1071,15 +1067,15 @@ def create_image(
10711067
body=marshal_CreateImageRequest(
10721068
CreateImageRequest(
10731069
root_volume=root_volume,
1074-
default_bootscript=default_bootscript,
1075-
public=public,
10761070
zone=zone,
10771071
name=name or random_name(prefix="img"),
10781072
arch=arch,
1073+
default_bootscript=default_bootscript,
10791074
extra_volumes=extra_volumes,
10801075
organization=organization,
10811076
project=project,
10821077
tags=tags,
1078+
public=public,
10831079
),
10841080
self.client,
10851081
),

scaleway/scaleway/instance/v1/types.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2036,7 +2036,7 @@ class CreateImageRequest:
20362036
Architecture of the image
20372037
"""
20382038

2039-
default_bootscript: str
2039+
default_bootscript: Optional[str]
20402040
"""
20412041
Default bootscript of the image
20422042
"""
@@ -2066,7 +2066,7 @@ class CreateImageRequest:
20662066
The tags of the image
20672067
"""
20682068

2069-
public: bool
2069+
public: Optional[bool]
20702070
"""
20712071
True to create a public image
20722072
"""

0 commit comments

Comments
 (0)