Skip to content

feat: handle region in certficate ID #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sh4d1 merged 1 commit into from
Feb 10, 2021
Merged

feat: handle region in certficate ID #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scaleway/loadbalancers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,6 +1489,17 @@ func getCertificateIDs(service *v1.Service, port int32) ([]string, error) {
ids = append(ids, strings.Split(split[1], ",")...)
}
}
// normalize the ids (ie strip the region prefix if any)
for i := range ids {
if strings.Contains(ids[i], "/") {
splitID := strings.Split(ids[i], "/")
if len(splitID) != 2 {
klog.Errorf("unable to get certificate ID from %s", ids[i])
return nil, fmt.Errorf("unable to get certificate ID from %s", ids[i])
}
ids[i] = splitID[1]
}
}

return ids, nil
}