Skip to content

Commit 54c3b3f

Browse files
Make project optional for get_tasks_count (#94)
1 parent e3c2d05 commit 54c3b3f

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

scaleapi/__init__.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ def get_tasks(
452452

453453
def get_tasks_count(
454454
self,
455-
project_name: str,
455+
project_name: str = None,
456456
batch_name: str = None,
457457
task_type: TaskType = None,
458458
status: TaskStatus = None,
@@ -470,7 +470,7 @@ def get_tasks_count(
470470
"""Returns number of tasks with given filters.
471471
472472
Args:
473-
project_name (str):
473+
project_name (str, optional):
474474
Project Name
475475
476476
batch_name (str, optional):
@@ -529,6 +529,11 @@ def get_tasks_count(
529529
Returns number of tasks
530530
"""
531531

532+
if not project_name and not batch_name:
533+
raise ValueError(
534+
"At least one of project_name or batch_name must be provided."
535+
)
536+
532537
tasks_args = self._process_tasks_endpoint_args(
533538
project_name,
534539
batch_name,

scaleapi/_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
__version__ = "2.15.12"
1+
__version__ = "2.15.13"
22
__package_name__ = "scaleapi"

tests/test_client.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,13 @@ def test_get_tasks_count():
417417
assert tasks_count == get_tasks_count
418418

419419

420+
def test_get_tasks_count_with_only_batch():
421+
batch = create_a_batch()
422+
tasks_count = client.tasks(batch=batch.name).total
423+
get_tasks_count = client.get_tasks_count(batch_name=batch.name)
424+
assert tasks_count == get_tasks_count
425+
426+
420427
def test_finalize_batch():
421428
batch = create_a_batch()
422429
batch = client.finalize_batch(batch.name)

0 commit comments

Comments
 (0)