Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

munit.Location incompatible with Gradle build caching and Distributed Testing #382

Closed
DanielThomas opened this issue Jun 22, 2021 · 1 comment · Fixed by #823
Closed

Comments

@DanielThomas
Copy link

The compiler macro embeds the fully qualified path to the source file for location at test runtime, however this causes the output to not be portable between machines, making it incompatible with Gradle build caching (or anything that wants to ship test artifacts outside the immediate build environment for that matter).

This also means that tests can't be distributed using the distributed test mechanism, as all resources need to be available via the classloader:

https://docs.gradle.com/enterprise/test-distribution-gradle-plugin/#tests_reading_files_from_src_test_resources

Attempting to locate source files as relative classloader resources before falling back to the file system would provide the flexibility necessary to implement support for both of these features downstream, and allow tests to be packaged with their sources in a standalone jar for running outside of the build tool.

@eed3si9n
Copy link
Contributor

Here's my PR for this - #823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants