Compatibility fixes

Author: ldaniels528

src/main/scala/io/scalajs/nodejs/Error.scala

@@ -11,6 +11,12 @@ import scala.scalajs.js.annotation.JSName
 @JSName("Error")
 class Error(message: String = "") extends js.Error(message) {
 
+  def code: String = js.native
+
+  def errno: String = js.native
+
+  def syscall: String = js.native
+
   def stack: js.Any = js.native
 
 }

src/main/scala/io/scalajs/nodejs/dns/DnsError.scala

@@ -9,14 +9,4 @@ import scala.scalajs.js
   * @author lawrence.daniels@gmail.com
   */
 @js.native
-class DnsError(message: String = "") extends Error(message) {
-
-  def code: String = js.native
-
-  def errno: String = js.native
-
-  def syscall: String = js.native
-
-  def hostname: String = js.native
-
-}
+class DnsError(message: String = "") extends Error(message)

src/main/scala/io/scalajs/nodejs/fs/FileIOError.scala

@@ -9,12 +9,4 @@ import scala.scalajs.js
   * @author lawrence.daniels@gmail.com
   */
 @js.native
-class FileIOError(message: String = "") extends Error(message) {
-
-  def code: String = js.native
-
-  def errno: String = js.native
-
-  def syscall: String = js.native
-
-}
+class FileIOError(message: String = "") extends Error(message)

src/main/scala/io/scalajs/nodejs/fs/ReadStream.scala

@@ -1,23 +1,25 @@
 package io.scalajs.nodejs.fs
 
+import io.scalajs.nodejs
 import io.scalajs.nodejs.FileDescriptor
-import io.scalajs.nodejs.stream.Readable
+import io.scalajs.nodejs.buffer.Buffer
 
 import scala.scalajs.js
+import scala.scalajs.js.|
 
 /**
   * fs.ReadStream - ReadStream is a Readable Stream.
   * @see https://nodejs.org/api/stream.html#stream_class_stream_readable
   */
 @js.native
-trait ReadStream extends Readable {
+trait ReadStream extends nodejs.stream.Readable {
 
   /**
     * The path to the file the stream is reading from as specified in the first argument to fs.createReadStream().
     * If path is passed as a string, then readStream.path will be a string. If path is passed as a Buffer, then
     * readStream.path will be a Buffer.
     */
-  def path: js.Any = js.native
+  def path: String | Buffer = js.native
 
 }
 

src/main/scala/io/scalajs/nodejs/http/ServerResponse.scala

@@ -12,7 +12,7 @@ import scala.scalajs.js
   * @see [[https://nodejs.org/api/http.html#http_class_http_serverresponse]]
   */
 @js.native
-trait ServerResponse extends IEventEmitter with Duplex {
+trait ServerResponse extends Duplex with IEventEmitter  {
 
   /////////////////////////////////////////////////////////////////////////////////
   //      Properties

src/main/scala/io/scalajs/nodejs/net/Socket.scala

@@ -15,7 +15,7 @@ import scala.scalajs.js.|
   */
 @js.native
 @JSImport("net", "Socket")
-class Socket extends Duplex {
+class Socket extends Duplex(js.native) {
 
   /////////////////////////////////////////////////////////////////////////////////
   //      Properties

src/main/scala/io/scalajs/nodejs/stream/Duplex.scala

@@ -1,7 +1,7 @@
 package io.scalajs.nodejs.stream
 
 import scala.scalajs.js
-import scala.scalajs.js.annotation.JSName
+import scala.scalajs.js.annotation.{JSName, ScalaJSDefined}
 
 /**
   * A "duplex" stream is one that is both Readable and Writable, such as a TCP socket connection.
@@ -15,17 +15,19 @@ import scala.scalajs.js.annotation.JSName
   * method on extension duplex classes.
   * @author lawrence.daniels@gmail.com
   */
-@js.native
-trait Duplex extends Readable with Writable {
-
-  /**
-    * Undocumented method
-    * @see https://github.com/nodejs/node-v0.x-archive/blob/cfcb1de130867197cbc9c6012b7e84e08e53d032/lib/fs.js#L1597-L1620
-    */
-  override def close(callback: js.Function = js.native): Unit = js.native
-
-}
-
 @js.native
 @JSName("Duplex")
-object Duplex extends DuplexClass
+class Duplex(options: DuplexOptions) extends Readable with Writable
+
+/**
+  * Duplex Options
+  * @param allowHalfOpen      If set to false, then the stream will automatically end the readable side
+  *                           when the writable side ends and vice versa (Default: true).
+  * @param readableObjectMode Sets objectMode for readable side of the stream. Has no effect if objectMode is true (Default: false).
+  * @param writableObjectMode Sets objectMode for writable side of the stream. Has no effect if objectMode is true (Default: false).
+  */
+@ScalaJSDefined
+class DuplexOptions(val allowHalfOpen: js.UndefOr[Boolean] = js.undefined,
+                    val readableObjectMode: js.UndefOr[Boolean] = js.undefined,
+                    val writableObjectMode: js.UndefOr[Boolean] = js.undefined)
+  extends js.Object

src/main/scala/io/scalajs/nodejs/stream/DuplexClass.scala

@@ -23,12 +23,6 @@ trait Readable extends IEventEmitter {
   //      Methods
   /////////////////////////////////////////////////////////////////////////////////
 
-  /**
-    * Undocumented method
-    * @see https://github.com/nodejs/node-v0.x-archive/blob/cfcb1de130867197cbc9c6012b7e84e08e53d032/lib/fs.js#L1597-L1620
-    */
-  def close(callback: js.Function = js.native): Unit = js.native
-
   /**
     * This method returns whether or not the readable has been explicitly paused by client code (using stream.pause()
     * without a corresponding stream.resume()).