Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add submission ID and URL as action outputs #115

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

laughedelic
Copy link
Contributor

This addresses some part of the intent described in #112. I didn't have time to delve into the plugin internals to fully address that feature request, but instead opted for this minimal change which allows a subsequent action to use the API endpoint to retrieve the snapshot of dependencies and work with it.

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@laughedelic
Copy link
Contributor Author

Could you rerun CI? I think it fails with 403 because a PR from an external contributor has a more limited token.

@adpi2
Copy link
Member

adpi2 commented Jul 5, 2023

Could you rerun CI? I think it fails with 403 because a PR from an external contributor has a more limited token.

I guess the CI will fail again with the 403. But I am okay to merge the PR and run the CI on main.

@laughedelic
Copy link
Contributor Author

Ok. I added the snapshot path output and updated the docs. I think it's ready

@laughedelic
Copy link
Contributor Author

Something that could potentially fix the CI is using pull_request_target trigger instead. But there are some security implications I'm not sure I understand fully.

@laughedelic laughedelic requested a review from adpi2 July 5, 2023 13:59
@laughedelic laughedelic requested a review from adpi2 July 5, 2023 15:17
@adpi2 adpi2 merged commit 8b31280 into scalacenter:main Jul 5, 2023
@laughedelic laughedelic deleted the feat/output-submission-info branch July 5, 2023 15:28
@laughedelic
Copy link
Contributor Author

laughedelic commented Jul 5, 2023

@adpi2
Copy link
Member

adpi2 commented Jul 6, 2023

It's all good. Since nothing changed in src/main.ts there is nothing to update.

@laughedelic
Copy link
Contributor Author

Oh, right, it makes sense. But could you release a new version of the plugin/action?

@laughedelic
Copy link
Contributor Author

@adpi2 could you cut a new release with these changes?

@adpi2
Copy link
Member

adpi2 commented Jul 10, 2023

https://github.com/scalacenter/sbt-dependency-submission/releases/tag/v2.2.0

Sorry for the delay.

@laughedelic
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants