-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add submission ID and URL as action outputs #115
feat: add submission ID and URL as action outputs #115
Conversation
86c4450
to
081e243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you rerun CI? I think it fails with 403 because a PR from an external contributor has a more limited token. |
I guess the CI will fail again with the 403. But I am okay to merge the PR and run the CI on main. |
Ok. I added the snapshot path output and updated the docs. I think it's ready |
Something that could potentially fix the CI is using |
sbt-plugin/src/main/scala/ch/epfl/scala/SubmitDependencyGraph.scala
Outdated
Show resolved
Hide resolved
@adpi2 thanks for merging! This looks good: https://github.com/scalacenter/sbt-dependency-submission/actions/runs/5466075693/jobs/9950467990#step:8:7 But I think |
It's all good. Since nothing changed in |
Oh, right, it makes sense. But could you release a new version of the plugin/action? |
@adpi2 could you cut a new release with these changes? |
https://github.com/scalacenter/sbt-dependency-submission/releases/tag/v2.2.0 Sorry for the delay. |
Thanks! |
This addresses some part of the intent described in #112. I didn't have time to delve into the plugin internals to fully address that feature request, but instead opted for this minimal change which allows a subsequent action to use the API endpoint to retrieve the snapshot of dependencies and work with it.