Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proofreading] Improve merge speed by not awaiting roundtrips #7969

Open
Tracked by #7619
philippotto opened this issue Aug 1, 2024 · 2 comments
Open
Tracked by #7619

[Proofreading] Improve merge speed by not awaiting roundtrips #7969

philippotto opened this issue Aug 1, 2024 · 2 comments

Comments

@philippotto
Copy link
Member

philippotto commented Aug 1, 2024

Currently, a merge operation:

  • blocks the user by entering a busy state
  • adapts the mapping locally (the rendered data is updated directly)
  • ensures a saved state (so that later mapping-requests provide correct values)
  • unblocks the user

Multiple ideas to improve this:

Idea 1: Don't ensure a saved state

  • when merging two ids A and B (e.g., so that B is changed to A) one can adapt the results of mapping-requests (that the server sent without knowing about the merge) by reassigning B to A
  • ensuring a saved state would not be necessary anymore then
  • however, split operations would need a new synchronization point (before and after the split; previously it was only after the split). the before-sync is only needed when a merge wasn't saved yet.

Idea 2: Don't block the user while ensuring a saved state

  • the user should be free to move around and inspect stuff. nothing bad should happen when only a save is pending. they don't need to know that wk is waiting for a save.
  • if the user does a split-operation after a merge, the merge needs to be awaited before the split operation is sent to the server, though. thus, we would defer the synchronization point.

Both ideas introduce additional complexity. I'd prefer doing (1) for now, since I have a bad feeling about dissolving the busy-blocking.

@philippotto philippotto mentioned this issue Aug 1, 2024
13 tasks
@philippotto philippotto changed the title Improve merge speed in proofreading tool by reducing roundtrips [Proofreading] Improve merge speed by reducing roundtrips Aug 1, 2024
@philippotto philippotto changed the title [Proofreading] Improve merge speed by reducing roundtrips [Proofreading] Improve merge speed by not awaiting roundtrips Aug 1, 2024
@hotzenklotz
Copy link
Member

@philippotto Is this issue completed with the recent magic mappings PR?

@philippotto
Copy link
Member Author

no, unfortunately not. this issue was created to suggest further improvements for the "magic mappings" performance. probably not high-pri for now, but it could definitely make the merge operation more snappy (think old merger-mode style).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants