Skip to content

Commit 00293e2

Browse files
authored
Fix loading adHocMeshes from dataset view mode (#8903)
Follow-up fix for #8708 (request must be by id now) ### URL of deployed dev instance (used for testing): - https://fixadhocviewmode.webknossos.xyz ### Steps to test: - Open a dataset with a static segmentation layer, request ad-hoc mesh for a segment, should load. ### Issues: - fixes https://scm.slack.com/archives/C02H5T8Q08P/p1757351922621309?thread_ts=1757338710.530969&cid=C02H5T8Q08P ------ - [x] Added changelog entry (create a `$PR_NUMBER.md` file in `unreleased_changes` or use `./tools/create-changelog-entry.py`) - [x] Considered [common edge cases](../blob/master/.github/common_edge_cases.md)
1 parent 01ec45c commit 00293e2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

frontend/javascripts/viewer/model/sagas/meshes/ad_hoc_mesh_saga.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -442,10 +442,9 @@ function* maybeLoadMeshChunk(
442442
threeDMap.set(clippedPosition, true);
443443
const scaleFactor = yield* select((state) => state.dataset.dataSource.scale.factor);
444444
const dataStoreHost = yield* select((state) => state.dataset.dataStore.url);
445-
const owningOrganization = yield* select((state) => state.dataset.owningOrganization);
446-
const datasetDirectoryName = yield* select((state) => state.dataset.directoryName);
445+
const datasetId = yield* select((state) => state.dataset.id);
447446
const tracingStoreHost = yield* select((state) => state.annotation.tracingStore.url);
448-
const dataStoreUrl = `${dataStoreHost}/data/datasets/${owningOrganization}/${datasetDirectoryName}/layers/${
447+
const dataStoreUrl = `${dataStoreHost}/data/datasets/${datasetId}/layers/${
449448
layer.fallbackLayer != null ? layer.fallbackLayer : layer.name
450449
}`;
451450
const tracingStoreUrl = `${tracingStoreHost}/tracings/volume/${layer.name}`;

unreleased_changes/8903.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Fixed
2+
- Fixed loading ad-hoc-computed meshes for static segmentation layers.

0 commit comments

Comments
 (0)