Use current compiler context to show Expr in macros #6258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
use-current-compiler-context-to-show-expr-in-macros
branch
from
6b57327 to
c05247a
Compare
ghost
removed
the
nicolasstucki
deleted the
use-current-compiler-context-to-show-expr-in-macros
branch
liufengyun
reviewed
Apr 9, 2019
|
|
||
| /** Show a source code like representation of this type */ | ||
| def show(implicit ctx: Context): String = | ||
| unseal.showCode |
There was a problem hiding this comment.
@nicolasstucki We need to allow one option color: Boolean = false here.
There was a problem hiding this comment.
It should be inheriting the one from the compiler. Is that the case?
There was a problem hiding this comment.
We should be able to create a new setting with the setting enabled or disabled
There was a problem hiding this comment.
In macro usage, usually, there will never be a need for colors -- because the text will be used for values. Inheriting from the compiler is not the correct behavior.
The Toobox settings does not work as expected. I currently use the following walkaround:
def (str: String) clean: String = str.replaceAll("\u001B\\[[;\\d]*m", "")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.