Skip to content

Documentation on the "companion object extension" type class pattern #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2019
Merged

Documentation on the "companion object extension" type class pattern #5774

merged 2 commits into from
Jan 22, 2019

Conversation

LPTK
Copy link
Contributor

@LPTK LPTK commented Jan 22, 2019

Closes #5694

dottybot
dottybot reviewed Jan 22, 2019
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@LPTK LPTK mentioned this pull request Jan 22, 2019
Closed
biboudis
biboudis suggested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, otherwise

@biboudis biboudis merged commit a98b901 into scala:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

@biboudis biboudis biboudis approved these changes

Assignees
No one assigned
Labels
area:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LPTK @biboudis @dottybot