Skip to content

Add dotty-library to generated docs #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Copy link
Contributor Author

@smarter this makes the genDocs generate the documentation for the dotty lib along with the compiler. Am I missing something else to make it published on the site?

smarter
smarter previously approved these changes Nov 23, 2018
@@ -420,7 +420,8 @@ object Build {

val sources =
unmanagedSources.in(Compile, compile).value ++
unmanagedSources.in(`dotty-compiler`, Compile).value
unmanagedSources.in(`dotty-compiler`, Compile).value ++
unmanagedSources.in(`dotty-library`, Compile).value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be dotty-library-bootstrapped, otherwise you'll misss the Scala 3-only files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buy adding dotty-library-bootstrapped (dc5a442) sbt crashes with a stack overflow.

http://dotty-ci.epfl.ch/lampepfl/dotty/8824/4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a fix, but genDocs now fails because it doesn't know how to handle MatchType, I'll let someone else fix that :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll work on the MatchType

This requires some sbt trickery to avoid loops when sbt loads the
settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants