-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add dotty-library to generated docs #5499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@smarter this makes the |
project/Build.scala
Outdated
@@ -420,7 +420,8 @@ object Build { | |||
|
|||
val sources = | |||
unmanagedSources.in(Compile, compile).value ++ | |||
unmanagedSources.in(`dotty-compiler`, Compile).value | |||
unmanagedSources.in(`dotty-compiler`, Compile).value ++ | |||
unmanagedSources.in(`dotty-library`, Compile).value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be dotty-library-bootstrapped, otherwise you'll misss the Scala 3-only files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buy adding dotty-library-bootstrapped
(dc5a442) sbt crashes with a stack overflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a fix, but genDocs
now fails because it doesn't know how to handle MatchType
, I'll let someone else fix that :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll work on the MatchType
dc5a442
to
4609aeb
Compare
This requires some sbt trickery to avoid loops when sbt loads the settings.
Now missing match types in docs
No description provided.