Partial function synthesis changesOwner of selector #23337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/23054-pf-crash
branch
from
dd2d3cc to
5d8f123
Compare
odersky
approved these changes
Jun 10, 2025
| @@ -6032,19 +6032,18 @@ object Types extends TypeUtils { | |||
| end samParent | |||
|
|
|||
| def samClass(tp: Type)(using Context): Symbol = tp match | |||
| case tp: ClassInfo => | |||
| val cls = tp.cls | |||
| case tp @ ClassInfo(_, cls, _, _, _) => | |||
There was a problem hiding this comment.
Nitpick: I much prefer the previous tp: ClassInfo to this see of underscores.
There was a problem hiding this comment.
I do not disagree. I grepped for similar usages so I conceded.
compiler/src/dotty/tools/dotc/core/TypeComparer.scala: case ClassInfo(_, cls, _, _, _) => cls.showLocated
I've forgotten whether I'm allowed to case ClassInfo(cls = cls) yet. I guess not. They say the chef is the last to eat, and it's the same with compiler features.
The selector expression may be non-trivial.
One would like to write ``` case tp @ ClassInfo(cls = cls) => ```
som-snytt
force-pushed
the
issue/23054-pf-crash
branch
from
5d8f123 to
25af420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector expression may be non-trivial.
Fixes #23054
Fixes #23025
Fixes #23310
The fix is the small refactor to
matchExpr.changeOwnerwhere previously only the cases were included.Another small refactor addresses an unused var.
There is a mild attempt to remedy the missing spec verbiage via a kind of post-script intended to suggest that it is a mere relaxation of the existing mechanism.